Closed Bug 1657204 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24878 - [WPT] Reland with fix: Test script's base URL used in dynamic imports

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24878 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24878
Details from upstream follow.

Hiroshige Hayashizaki <hiroshige@chromium.org> wrote:

[WPT] Reland with fix: Test script's base URL used in dynamic imports

This CL checks base URL used in resolving relative URL-like
specifiers in dynamic imports() from

  • \<script>s,
  • worker top-level scripts, and
  • worker scripts imported by importScripts().

This is for https://github.com/whatwg/html/issues/5751.

This CL relands
https://chromium-review.googlesource.com/c/chromium/src/+/2198835/
with a fix:

base-url-worker.sub.html was flaky due to
race between two fetch_tests_from_worker()s.
In this reland, a fetch_tests_from_worker() is
moved to a new file base-url-worker-importScripts.html,
having at most one fetch_tests_from_worker() per file.

Bug: 1082086, 1112844
Change-Id: I59c9817a7829e950f40878d376ccb5216207b7e8

Reviewed-on: https://chromium-review.googlesource.com/2337194
WPT-Export-Revision: 82bd5676520aeb52da30dedcb87ecdbfce051769

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 4 subtests

Status Summary

Firefox

OK : 3
PASS: 8
FAIL: 6

Chrome

OK : 3
PASS: 9
FAIL: 5

Safari

OK : 3
PASS: 8
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url.sub.html
Relative URL-like from cross origin classic <script> without crossorigin attribute: FAIL (Chrome: FAIL, Safari: FAIL)
/html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url-worker.sub.html
Absolute URL-like from worker top-level script: FAIL (Chrome: PASS, Safari: FAIL)
Relative URL-like from worker top-level script: FAIL (Chrome: PASS, Safari: FAIL)
/html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url-worker-importScripts.html
Relative URL-like from same-origin importScripts(): FAIL (Chrome: FAIL, Safari: FAIL)
Absolute URL-like from cross-origin importScripts(): FAIL (Chrome: PASS, Safari: FAIL)
Absolute URL-like from same-origin importScripts(): FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0f2204acb9ca [wpt PR 24878] - [WPT] Reland with fix: Test script's base URL used in dynamic imports, a=testonly https://hg.mozilla.org/integration/autoland/rev/1272319958c3 [wpt PR 24878] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ca847b5bfdb1 [wpt PR 24878] - [WPT] Reland with fix: Test script's base URL used in dynamic imports, a=testonly https://hg.mozilla.org/integration/autoland/rev/fea41147ac29 [wpt PR 24878] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/ca847b5bfdb1
https://hg.mozilla.org/mozilla-central/rev/fea41147ac29

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.