Encryption status shown incorrectly for some replies to encrypted messages
Categories
(MailNews Core :: Security: OpenPGP, defect)
Tracking
(thunderbird_esr78 fixed, thunderbird80 fixed)
People
(Reporter: KaiE, Assigned: KaiE)
Details
Attachments
(1 file)
|
47 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
wsmwk
:
approval-comm-esr78+
|
Details | Review |
enigmailMsgComposeOverlay.js function decryptQuote calls nsISelectionController.completeMove.
I see an exception from that function, when replying to certain encrypted messages, but some work fine. I don't yet understand the differences that trigger the failure.
This has a bad side effect. When replying to an encrypted message, processing is interrupted, and we don't reach the code that enables encryption for the reply.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
After testing the potential fix (wrapping the failing call into try/catch), I still saw the symptom.
But my previous report of the symtop was wrong.
Encryption IS actually enabled correctly. But the user interface isn't showing it!
For some reason, the status bar doesn't show the encryption icon. However, when opening the menu, it shows that encryption is enabled.
|
|
Assignee | |
Comment 3•4 years ago
|
||
My earlier interpretation was incorrect. We do enable the flag to encrypt.
The missing status bar feedback is caused by bad timing of events.
We only call setEncSigStatusUI once, from ComposeLoad and adjustSignEncryptAfterIdentityChanged.
With the problematic message, there is a double encoding. We have inline OpenPGP. And that inline OpenPGP uses a base64 content transfer encoding.
When replying, initially the base64 encoding is decoded and the BEGIN PGP message is loaded (and temporarily shown) into the composer window. Then it is automatically decrypted.
This series of events means that the message properties are known at a later time, after the initial call to setEncSigStatusUI.
|
|
Assignee | |
Comment 4•4 years ago
|
||
Ok, the only problem is that the display isn't updated after the last processing step.
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
Pushed by kaie@kuix.de:
https://hg.mozilla.org/comm-central/rev/c5124f13d00b
Encryption status shown incorrectly for some replies to encrypted messages. r=mkmelin DONTBUILD
Pushed by kaie@kuix.de: https://hg.mozilla.org/comm-central/rev/a10b7ee9fb6b Follow-up to fix lint. rs=lint DONTBUILD
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 7•4 years ago
|
||
phab updated to include lint fix
|
|
Assignee | |
Comment 8•4 years ago
|
||
Comment on attachment 9168036 [details]
Bug 1657245 - Encryption status shown incorrectly for some replies to encrypted messages. r=mkmelin
OpenPGP correctness fix. No risk
|
||
Comment 9•4 years ago
|
||
Comment on attachment 9168036 [details]
Bug 1657245 - Encryption status shown incorrectly for some replies to encrypted messages. r=mkmelin
[Triage Comment]
Approved for beta
|
|
Assignee | |
Comment 10•4 years ago
|
||
|
|
||
Comment 11•4 years ago
|
||
Comment on attachment 9168036 [details]
Bug 1657245 - Encryption status shown incorrectly for some replies to encrypted messages. r=mkmelin
[Triage Comment]
Approved for esr78
|
|
Assignee | |
Comment 12•4 years ago
|
||
Description
•