Hard-code MIME-extension mappings for FLAC and AAC
Categories
(Firefox :: File Handling, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | verified |
People
(Reporter: evilpie, Assigned: evilpie)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
Looking at the nsExtraMimeTypeEntry array I think FLAC and AAC are two obvious additions that could be made. For both I looked up the appropriate extension on Wikipedia. For FLAC there was only a single extension .flac, that I have personally encountered so that seems fine. For AAC wikipedia lists various container formats etc. I chose just .aac for the audio format.
|
Assignee | |
Comment 1•4 years ago
|
||
|
||
Comment 2•4 years ago
|
||
Per spec we should only determine what a type is through sniffing ; not using the file typename.
|
|
Assignee | |
Comment 3•4 years ago
|
||
I think this is basically outside spec territory. We use this list for various cases where we don't sniff. There is no good reason to not add these specific MIME types here, when we already support most other image, video and audio MIME types anyway.
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/df7c9cae79be Hard-code MIME-extension mappings for FLAC and AAC. r=jya,Gijs
|
||
Comment 5•4 years ago
|
||
| bugherder | ||
|
||
Comment 7•4 years ago
|
||
The FLAC part is verified with 81.0a1 (2020-08-10).
However, for AAC; as far as I can see it saves files as mp4 on Windows 10.
Tried with 1; 2; or is it intended on Windows-OS?
|
|
Assignee | |
Comment 8•4 years ago
|
||
These files seem to have an .mp4 file extension. I am not sure how we decide to display the description, but mp4 files are containers and can contain any kind of audio/video.
https://docs.espressif.com/projects/esp-adf/en/latest/design-guide/audio-samples.html seems to have AAC files with the .aac extension that we are handling.
|
|
||
Comment 9•4 years ago
|
||
You are right, thank you for the input!
Confirmed for AAC as well.
Description
•