1657316 - Perma bustage mozbuild.preprocessor.Error: ('$SRCDIR/modules/libpref/init/StaticPrefList.yaml', 255, 'UNDEFINED_VAR', 'NIGHTLY_BUILD') when Gecko 81 merges to Beta on 2020-08-24

Status: VERIFIED FIXED

(Core :: Panning and Zooming, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=1def68abd04c6dc6c882160dfc5d0c817b25bd34&group_state=expanded&selectedTaskRun=ONgLhh4gRBKndvJmNgNOBQ.0

Log: https://treeherder.mozilla.org/logviewer.html#?job_id=312118444&repo=try
mozbuild.preprocessor.Error: ('$SRCDIR/modules/libpref/init/StaticPrefList.yaml', 255, 'UNDEFINED_VAR', 'NIGHTLY_BUILD')

Introduced by https://hg.mozilla.org/mozilla-central/rev/a09e4ce9ebba8fa4a29a4833560c8ee807018c03#l1.16 - @IS_NIGHTLY_BUILD@ should fix it.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Oops. How does this even work on nightly then, I wonder?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

We are clobbering nightly right now for similar failures.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1657316 - Fix variable used for nightly build selection. r?Aryx

Comment 4

[Kartikaya Gupta (email:[e-mail])]

In my local build it looks like @NIGHTLY_BUILD@ expands to 1 so it works ok as a bool. Presumably the try pushes I did also did the same thing.

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #2)

We are clobbering nightly right now for similar failures.

Can you elaborate on this? I see a clobber push on m-c tip but it seems related to some NSS change. I want to understand the failure mode a bit better, maybe this is something that should be caught by the StaticPrefsList.yaml preprocessor.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Mark, can you provide some insight about the need for the clobber, please?

Comment 6

[Mark Banner (:standard8)]

The clobber I requested was indeed for the NSS change - it seemed that bug 1655105 moved a file which broke dep builds. As is discussed in bug 1657328.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0127836686db
Fix variable used for nightly build selection. r=aryx

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0127836686db

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with yesterday's central-as-beta simulation.