1657322 - Crash in [@ InvalidArrayIndex_CRASH | nsMessenger::SaveAllAttachments]

Status: RESOLVED FIXED

(MailNews Core :: Attachments, defect)

Description

[Wayne Mery (:wsmwk)]

This bug is for crash report bp-f1cae35a-f51a-472b-b86b-f7f370200804.
Top 10 frames of crashing thread:

0 xul.dll InvalidArrayIndex_CRASH xpcom/ds/nsTArray.cpp:27
1 xul.dll nsMessenger::SaveAllAttachments comm/mailnews/base/src/nsMessenger.cpp
2 xul.dll nsMessenger::SaveAllAttachments comm/mailnews/base/src/nsMessenger.cpp:833
3 xul.dll XPTC__InvokebyIndex 
4  @0x2597ffbda7 
5 xul.dll truncf 
6 xul.dll truncf 
7 xul.dll static XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1140
8 xul.dll XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:946
9 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:585

Crash first seen with buildid 20200428163452 version 76 bp-cb2a4015-c308-4daf-89c8-3a5720200507
So far, all crashes on Windows

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1657322_saveall_crash.patch

Apparently crashing on one of the [0] accesses for a 0 long array. I don't know how js ever ends up calling that.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/10e8b269da64
fix Crash in [@ InvalidArrayIndex_CRASH | nsMessenger::SaveAllAttachments]. r=benc

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9168124 [details] [diff] [review]
bug1657322_saveall_crash.patch

[Approval Request Comment]
Crash fix, very safe.

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9168124 [details] [diff] [review]
bug1657322_saveall_crash.patch

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 80.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/b52c1778f353

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9168124 [details] [diff] [review]
bug1657322_saveall_crash.patch

[Triage Comment]
Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/a72ba40b404b