1657351 - The selected theme is reset if you navigate back to the about:welcome page and select the `Not now` option

Status: RESOLVED DUPLICATE of bug 1654122

(Firefox :: Messaging System, defect)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

Attachment: selected theme is reset after navigating back to the welcome_theme page.gif

[Affected versions]:

• Firefox Beta 80.0b3, Build ID 20200803045446
• Firefox Nightly 81.0a1, Build ID 20200803094100

[Affected Platforms]:

• Windows 10
• macOS 10.15
• Linux MX 4.19

[Steps to reproduce]:

1. Open Firefox Beta with a clean new profile.
2. Navigate to the 3rd slide of the onboarding.
3. Select a theme that is the opposite of the default OS theme (light if OS dark, dark if OS light).
4. Click the Save Theme button.
5. Click the Browser's Back button and select the Not now option.
6. Observe the behavior.

[Expected results]:

• The theme set at Step 3 is kept.

[Actual results]:

• The theme is reset to Automatic.

[Notes]:

• Attached a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

This is a known issue and related to bug 1654122. Current implementation of 'Choose a look' screen, install theme during live preview when user clicks on a theme option. Click of 'Not Now' revert installed theme to default system theme.

To handle edge cases such as back navigation after installing theme, we need to read any previously installed theme on theme screen load and use it to highlight previously installed theme and revert to previously installed theme on click of 'Not Now'.