Closed Bug 1657418 Opened 8 months ago Closed 7 months ago

Add links to VoiceOver Rotor

Categories

(Core :: Disability Access APIs, defect, P1)

Desktop
macOS
defect

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: morgan, Assigned: morgan)

References

Details

Attachments

(1 file, 2 obsolete files)

STR:

  1. Load data:text/html,<a href="">empty link</a><br><a href="google.com">google</a><br><a>no href</a>
  2. Activate VO
  3. Press VO+U

Expected:
Links menu shows with "empty link", "google"

Actual:
No links are shown

Assignee: nobody → mreschenberg
Blocks: 1657505
Severity: -- → S3
Priority: -- → P1
Attachment #9168299 - Attachment is obsolete: true
Attachment #9174786 - Attachment description: Bug 1657418: Add visited, unvisited links, regular links, AXLinkUIElements to web area. → Bug 1657418: Add visited, unvisited links, regular links to rotor and AXLinkUIElements to web area. r?eeejay
Attachment #9176142 - Attachment is obsolete: true
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b344e00670b
Add visited, unvisited links, regular links to rotor and AXLinkUIElements to web area. r=eeejay
Blocks: 1665761

Backed out for bustage on MOXWebAreaAccessible.mm

backout: https://hg.mozilla.org/integration/autoland/rev/34a7f73d0ea4bf45a792206d8358498be9c1030d

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5b344e00670bd573242e3421530b6f272de3cbd1

push where the bustages appeared: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=ej3xQdDoSGqELpqYcizs4Q.0&revision=655698c18737242eda9190ce601a19b54c3826ef&searchStr=os%2Cx%2Ccross%2Ccompiled

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315982829&repo=autoland&lineNumber=9131

[task 2020-09-17T22:04:30.470Z] 22:04:30 INFO - In file included from Unified_mm_accessible_mac0.mm:83:
[task 2020-09-17T22:04:30.470Z] 22:04:30 ERROR - /builds/worker/checkouts/gecko/accessible/mac/MOXWebAreaAccessible.mm:75:17: error: method definition for 'moxUnignoredChildren' not found [-Werror,-Wincomplete-implementation]
[task 2020-09-17T22:04:30.470Z] 22:04:30 INFO - @implementation MOXWebAreaAccessible
[task 2020-09-17T22:04:30.471Z] 22:04:30 INFO - ^
[task 2020-09-17T22:04:30.471Z] 22:04:30 INFO - /builds/worker/checkouts/gecko/accessible/mac/MOXWebAreaAccessible.h:30:1: note: method 'moxUnignoredChildren' declared here
[task 2020-09-17T22:04:30.471Z] 22:04:30 INFO - - (NSArray*)moxUnignoredChildren;
[task 2020-09-17T22:04:30.472Z] 22:04:30 INFO - ^
[task 2020-09-17T22:04:30.472Z] 22:04:30 INFO - In file included from Unified_mm_accessible_mac0.mm:83:
[task 2020-09-17T22:04:30.472Z] 22:04:30 ERROR - /builds/worker/checkouts/gecko/accessible/mac/MOXWebAreaAccessible.mm:75:17: error: method definition for 'dealloc' not found [-Werror,-Wincomplete-implementation]
[task 2020-09-17T22:04:30.472Z] 22:04:30 INFO - @implementation MOXWebAreaAccessible
[task 2020-09-17T22:04:30.473Z] 22:04:30 INFO - ^
[task 2020-09-17T22:04:30.473Z] 22:04:30 INFO - /builds/worker/checkouts/gecko/accessible/mac/MOXWebAreaAccessible.h:36:1: note: method 'dealloc' declared here
[task 2020-09-17T22:04:30.473Z] 22:04:30 INFO - - (void)dealloc;
[task 2020-09-17T22:04:30.473Z] 22:04:30 INFO - ^

Flags: needinfo?(mreschenberg)
Flags: needinfo?(mreschenberg)
Pushed by mreschenberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30660f927c45
Add visited, unvisited links, regular links to rotor and AXLinkUIElements to web area. r=eeejay
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Regressions: 1668100
Regressions: 1668142
Regressions: 1668137
Regressions: 1681909
You need to log in before you can comment on or make changes to this bug.