1657478 - Support recommendation states for abuse reporting

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, enhancement, P5)

Description

[Shane Caraveo (:mixedpuppy)]

queryAMOAddonDetails returns a boolean flag for isRecommended, we may need to support more than just the recommended state.

https://searchfox.org/mozilla-central/rev/b4f3ce16c5099cf068fb023341959a0457adec9e/toolkit/mozapps/extensions/AbuseReporter.jsm#270

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

So, the isRecommended state is sent with the abuse report? We could just stop sending that, since AMO has all the info it needs to determine if something is recommended or not (guid + version). Same with the other states.

Comment 2

[Mathieu Pillard [:mat]]

Having Firefox send this data could be valuable still for some extreme cases where AMO doesn't have the data somehow. Ultimately that info is currently only displayed in Abuse Reports admin tool though, not reviewer tools, so it might not be very important.

If we want to continue sending the data, we would need to take into account the new promoted states in both Firefox and the API to support that.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

Given the way we look at abuse report data, I can't imagine a situation where we need this bit of data and can't get it elsewhere. I'm in favor of dropping it.

Comment 4

[William Durand [:willdurand]]

It doesn't look like we are going to fix this ticket any time soon, especially since the abuse reporter UI is going to be removed in Bug 1893116.