Closed Bug 1657530 Opened 4 years ago Closed 4 years ago

Turn on pocket stories in Ireland

Categories

(Firefox :: New Tab Page, enhancement)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox80 + verified
firefox81 + verified

People

(Reporter: thecount, Assigned: thecount)

Details

Attachments

(1 file)

Bug 1657530 - Enable Ireland region for newtab stories.
47 bytes, text/x-phabricator-request
jcristau
: approval-mozilla-beta+
Details | Review

Pref flip, likely an uplift, for newtab stories in Ireland.

Assignee: nobody → sdowne

To test:

  1. Using an en-us/GB/CA browser.
  2. Set browser.search.region to IE.
  3. Restart.

expected: Should see 7 rows of Pocket stories.

[Tracking Requested - why for this release]: Just a pref flip to turn on Pocket newtab stories in Ireland.

status-firefox80: --- → affected
status-firefox81: --- → affected
tracking-firefox80: --- → ?
tracking-firefox81: --- → ?
Status: NEW → ASSIGNED
Pushed by sdowne@getpocket.com:
https://hg.mozilla.org/integration/autoland/rev/2595ce492268
Enable Ireland region for newtab stories. r=gvn

https://hg.mozilla.org/mozilla-central/rev/2595ce492268

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Comment on attachment 9168502 [details]
Bug 1657530 - Enable Ireland region for newtab stories.

Beta/Release Uplift Approval Request

  • User impact if declined: Turning on Pocket stories in Ireland, so user in Ireland wouldn't see Pocket stories for an extra month.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: To test:
  1. Using an en-us/GB/CA browser.
  2. Set browser.search.region to IE.
  3. Restart.

expected: Should see 7 rows of Pocket stories.

  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): it's a pref flip that turns on code that's already on and being used by US, CA, DE, and GB.
  • String changes made/needed: none
Attachment #9168502 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9168502 [details]
Bug 1657530 - Enable Ireland region for newtab stories.

approved for 80.0b7

Attachment #9168502 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified this enhancement and I can confirm that 7 rows of "Pocket" stories (3 stories on each row) are displayed after the "browser.search.region" pref is set to "IE".

Verified using the latest Firefox Nightly en-US locale build (81.0a1 Build ID - 20200810213634) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.

Status: RESOLVED → VERIFIED
status-firefox81: fixed → verified

I have verified this enhancement and I can confirm that 7 rows of "Pocket" stories (3 stories on each row) are displayed after the "browser.search.region" pref is set to "IE".

Verified using the latest Firefox Beta en-US locale build (80.0b7 Build ID - 20200811133449) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.

status-firefox80: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: