1657537 - Move components shared by tooltip and Compatibility Panel to common location

Status: RESOLVED FIXED

(DevTools :: Inspector: Compatibility, enhancement, P3)

Description

[Kriyszig]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0

Expected results:

With the introduction of the CSS Compatibility Tooltip, there will be React components shared between the compatibility panel and the tooltip.
Based on the discussion, we will move the shared components to devtools/client/inspector/compatibility and move MDNCompatibility library in devtools/client/shared/compatibility to devtools/server/actors/compatibility to reduce fragmentation in the compatibility ecosystem.

Comment 1

[Kriyszig]

Attachment: Bug 1657537 - Part 1 - Move the ISSUE_TYPE property to devtools/shared/constants.js r=daisuke,mtigley

Most of the MDNCompatibility library imports on the client side
is just to access the property MDNCompatibility.ISSUE_TYPE.
This patch moves the property into constants.js in devtools/shared
from where it can be accessed both client and server side.
The issue types are constants and is exported as COMPATIBILITY_ISSUE_TYPE

Comment 2

[Kriyszig]

Attachment: Bug 1657537 - Part 2 - Move MDNCompatibility library and related files to devtools/server/actors/compatibility r=daisuke,mtigley

This moves the MDNCompatibility library and the related datasets
and tests to the server side. It also moves the compatibility actor
file intot he compatibility directory.
The links to these files have been updated and the library tests have
been moved to the new location.

Depends on D86519

Comment 3

[Kriyszig]

Attachment: Bug 1657537 - Part 3 - Move shared component between compatibility panel and compatibility tooltip to devtools/client/shared folder r=mtigley,daisuke

This patch moves the UnsupportedBrowserList React component and it's dependencies
to devtools/client/shared/compatibility
All the paths linked to the moved components have been updated to
point to the components in shared folder

Depends on D86521

Comment 4

[Kriyszig]

Attachment: Bug 1657537 - Part 4 - Move snapshot tests for shared components from inspector/compatibility to shared/compatibility r=ladybenko!,daisuke,mtigley

This patch moves the snapshot
tests for the components shared between the compatibility panel and the
compatibility tooltip to shared/compatibility/test/node
The components UnsupportedBrowserList and UnsupportedBrowserItem
were moved to devtools/client/shared/compatibility in D83909.
The lock files and configs are copied from
devtools/client/inspector/compatibility/test/node and are exactly
identical except for the package name in package.json

Depends on D86522

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d39dc81e9644
Part 1 - Move the ISSUE_TYPE property to devtools/shared/constants.js r=mtigley
https://hg.mozilla.org/integration/autoland/rev/b17538791df6
Part 2 - Move MDNCompatibility library and related files to devtools/server/actors/compatibility r=daisuke,mtigley

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d39dc81e9644
https://hg.mozilla.org/mozilla-central/rev/b17538791df6