1657607 - Make the alarm dialog themeable

Status: VERIFIED FIXED

(Calendar :: Dialogs, task)

Description

[Richard Marti (:Paenglab)]

We can also make the alarm dialog themeable.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1657607-alarm-dialog-themeable.patch

Make it themeable.

Comment 2

[Paul Morris [:pmorris]]

Comment on attachment 9168479 [details] [diff] [review]
1657607-alarm-dialog-themeable.patch

Review of attachment 9168479 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good to me.

::: calendar/base/themes/common/dialogs/calendar-alarm-dialog.css
@@ +96,5 @@
>      border: 1px dotted ThreeDDarkShadow;
>      padding: 0;
>  }
> +
> +:root[lwt-tree] #alarm-snooze-all-popup ,

There's an extra space before the comma here.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: 1657607-alarm-dialog-themeable.patch

Fixed the space before the comma.

[Approval Request Comment]
User impact if declined: no dark alarms dialog with dark theme
Testing completed (on c-c, etc.): ready to land on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Richard Marti (:Paenglab)]

Attachment: 1657607-alarm-dialog-themeable-ESR.patch

[Approval Request Comment]
User impact if declined: no dark alarms dialog with dark theme
Testing completed (on c-c, etc.): ready to land on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9168540 [details] [diff] [review]
1657607-alarm-dialog-themeable.patch

[Triage Comment]
Approved for beta

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e52ca0a93578
Make the alarm dialog themeable. r=pmorris

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 80.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/80b8a4c0e9df

Comment 8

[WaltS48 [:walts48]]

Looks good in my testing of 80.0b3 release candidate on Ubuntu 18.04.4 LTS.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9168541 [details] [diff] [review]
1657607-alarm-dialog-themeable-ESR.patch

[Triage Comment]
Approved for esr78

Comment 10

[Geoff Lankow (:darktrojan)]

Thunderbird 78.2.0:
https://hg.mozilla.org/releases/comm-esr78/rev/c1c1b0c98c83

Comment 11

[Geoff Lankow (:darktrojan)]

Bonus push to clear up a CSS problem:
https://hg.mozilla.org/releases/comm-esr78/rev/c2ec46e881e7b3f3bf164ff668726bf215e6a6de