1657626 - Remove Firefox Send from accounts panel in Firefox

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, task)

Description

[John Gruen [:jgruen]]

We should turn the pref that displays send off on the accounts panel

Comment 1

[Vijay Budhram]

We should be able to set the at [1] to an empty string and the menu should automatically get removed.

[1] - https://dxr.mozilla.org/mozilla-central/source/browser/app/profile/firefox.js#1918

Comment 2

[Vijay Budhram]

Attachment: Bug 1657626 - Remove send from fxa toolbar menu

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32c70539a911
Remove send from fxa toolbar menu r=markh

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/32c70539a911

Comment 5

[Vijay Budhram]

:malexandru I would like to uplift this patch to our current beta FF 80. From [1], I don't see an uplift flag in bugzilla, is there a new way to do this?

[1] - https://wiki.mozilla.org/Release_Management/Uplift_rules#Beta_Uplift_.28approval-mozilla-beta.29

Comment 6

[Alexandru Michis [:malexandru]]

Hello, the way to do this is by making and uplift approval request and by setting the "approval-mozilla-beta" flag to "?" as seen here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1653125#c14
Then wait for the person who is taking care of the current beta cycle to give you approval and then land it.

The rules seem to be the ones you pointed out, but I can't find the documentation where the approval request is found, so I guess you could copy that one and modify the fields as you need.

Comment 7

[Vijay Budhram]

Comment on attachment 9169670 [details]
Bug 1657626 - Remove send from fxa toolbar menu

Beta/Release Uplift Approval Request

• User impact if declined: They would be shown the Firefox Send button in the FxA toolbar menu. The service is currently resolving some issues and doesn't have a timeline for being back up.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is not risky because the change is only a preference change to toggle the visibility of a button menu.
• String changes made/needed: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9169670 [details]
Bug 1657626 - Remove send from fxa toolbar menu

81 is already on Beta (and 80 is on release). That said, do we want to consider this for a dot release ride-along and/or ESR78 uplift?

Comment 9

[Wil Clouser [:clouserw]]

The Send service is down and has no ETA on coming back up, so, removing the link is a good plan.

Riding a dot release feels like the right amount of stress here (read: low) and uplifting to ESR78 is a good idea too.