1657628 - Problem with f32x4.min, broken test runner

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, defect, P3)

Description

[Lars T Hansen [:lth]]

There's a bug in ad-hack.js where the function 'eq' is defined twice with different semantics, thus removing a bunch of test cases from the float operations, notably including infinities and NaN. Fixing this by renaming the first definition as 'equal' reveals that there are test cases that are not passing, it looks like f32x4.min is the first to fail. That one needs to be fixed anyway, but let's first find out what's up here.

Comment 1

[Lars T Hansen [:lth]]

Attachment: Bug 1657628 - Fix bugs in some ad-hack simd tests. r?jseward

For floating point, max and min are more complicated and we have to
use the appropriate logic. This bug was masked because of a different
bug in the test suite that prevented us from running NaN tests.

Depends on D85982

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6d240ef908b
Fix bugs in some ad-hack simd tests. r=jseward

Comment 3

[Cosmin Sabou [:CosminS]]

Backed out for SM bustages.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=c19dcb11b94077f23bf41515a0c2584406823815&selectedTaskRun=bmV7w4-AQZKWk_E5UMOMHg.0

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=312801749&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=312801766&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/2ce43b1fe3db5a3121cb01e5ea3045da7b85b1c9

Comment 4

[Lars T Hansen [:lth]]

A problem in bug 1656226, it needed to tweak some tests.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c9edf20c004
Fix bugs in some ad-hack simd tests. r=jseward

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5c9edf20c004