Closed Bug 1657628 Opened 6 months ago Closed 5 months ago

Problem with f32x4.min, broken test runner

Categories

(Core :: Javascript: WebAssembly, defect, P3)

x86_64
Linux
defect

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(1 file)

There's a bug in ad-hack.js where the function 'eq' is defined twice with different semantics, thus removing a bunch of test cases from the float operations, notably including infinities and NaN. Fixing this by renaming the first definition as 'equal' reveals that there are test cases that are not passing, it looks like f32x4.min is the first to fail. That one needs to be fixed anyway, but let's first find out what's up here.

For floating point, max and min are more complicated and we have to
use the appropriate logic. This bug was masked because of a different
bug in the test suite that prevented us from running NaN tests.

Depends on D85982

Attachment #9168703 - Attachment description: Bug 1657628 - Fix bugs in ad-hack simd tests. r?jseward → Bug 1657628 - Fix bugs in some ad-hack simd tests. r?jseward
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6d240ef908b
Fix bugs in some ad-hack simd tests. r=jseward

A problem in bug 1656226, it needed to tweak some tests.

Flags: needinfo?(lhansen)
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c9edf20c004
Fix bugs in some ad-hack simd tests. r=jseward
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.