1657703 - /me on doesn't remove input from the input box

Status: VERIFIED FIXED

(Chat Core :: IRC, defect)

Description

[Jorg K (CEST = GMT+2)]

Attachment: 2020-08-06 21_14_59-Window.png

/me on a private IRC channel (/msg) doesn't remove input from the input box (on server with echo-message support), see picture.

Comment 1

[Patrick Cloke [:clokep]]

Attachment: Patch v1

This fixes a broken reference to the account object.

Comment 2

[Khushil Mistry [:khushil324]]

Comment on attachment 9168598 [details] [diff] [review]
Patch v1

Review of attachment 9168598 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. r=khushil

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 9168598 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Regression caused by (bug #): bug 1649445
User impact if declined: "/me foo" won't clear from the input box after sending an action message on IRC
Testing completed (on c-c, etc.): I tested this manually, it has not yet hit c-c
Risk to taking this patch (and alternatives if risky): I think this patch is pretty low risk -- the fix takes place at the end of the command processing, so worse case is that we end up with the same behavior.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f4d55eb713d0
/me command should clear the text from the text input. r=khushil

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9168598 [details] [diff] [review]
Patch v1

[Triage Comment]
Approved for beta

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 80.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/2896e167946f

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9168598 [details] [diff] [review]
Patch v1

[Triage Comment]
Approved for esr78

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.1.2:
https://hg.mozilla.org/releases/comm-esr78/rev/52522213a462

Comment 9

[Jorg K (CEST = GMT+2)]

Works in the latest ESR build.