1657742 - Middle button clicking on a tweet in the desktop version of Twitter invokes the popup blocker

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Mike Kaply [:mkaply]]

If you're viewing the desktop version of twitter and middle click on a tweet, the popup blocker is invoked.

It should open the tweet in a new (background) tab.

Works in Chrome

Comment 1

[Mike Taylor [:miketaylr]]

Attachment: screenshot of relevant window.open call (maybe?)

If you break here in https://abs.twimg.com/responsive-web/web/main.0396ccb5.js (or whatever the file will be):

t.type is mouseup, which seems like it should be fine, according to https://searchfox.org/mozilla-central/source/modules/libpref/init/all.js#990

Comment 2

[Edgar Chen [:edgar]]

I could not reproduce it on Nightly, nor 78 (on Mac).
What version of Firefox you are using?
Could you test it again with a clean profile and all add-on disabled? Thanks.

Comment 3

[Mike Kaply [:mkaply]]

I see it on nightly and release, no addons.

And Mike Taylor was seeing it to.

Just tested and I still see it.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Physical mouse button events (i.e., mousedown and mouseup) may be allowed only when the button is the primary button.
https://searchfox.org/mozilla-central/rev/ab81b8552f4aa9696a2524f97fdfeb59d4dc31c1/dom/base/PopupBlocker.cpp#300,303,308
I think that this limitation is odd.

baku: Why do we limit the button?

Comment 5

[Andrea Marchesini [:baku]]

Attachment: Bug 1657742 - PopupBlocker doesn't block Middle mouse button click, r?smaug

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f017088f2e1
PopupBlocker doesn't block Middle mouse button click, r=smaug

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4f017088f2e1