1657791 - Remove GPU cache usage from clip mask rendering

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1657791 - Remove GPU cache usage from clip mask instances.

The patch removes use of the GPU cache when rendering
clip mask instances. Instead, each clip mask type now
has a specific vertex format and passes the information
for the clip mask via vertex attributes.

As part of future clip-chain optimization work, the
ClipNode type will be removed entirely (instead, clip
chains will be optimized during scene building into
a clip set per primitive). Removing GPU cache usage here
simplifies some of that work, and using GPU cache handles
here provides no major benefit over vertex attributes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8385068f5dd
Remove GPU cache usage from clip mask instances. r=kvark,jnicol

Comment 3

[Razvan Maries]

Backed out for Reftests perma failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=6e4e8ed124cda6c0e20efe7b0d93655c62b8b958&searchStr=reftests&selectedTaskRun=eOvp8VcQQQqfDfgUyCaCMA.0

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312658902&repo=autoland&lineNumber=1929

Backout: https://hg.mozilla.org/integration/autoland/rev/2a4fef8f0dafc37893aaaa9ae12834666b37fc80

Comment 4

[Glenn Watson [:gw]]

This appears to be caused by a bug in the SWGL library - I've created a patch to fix that in [1]. Once that gets reviewed and landed, I will re-land this.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1658467

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/78f75a74c554
Remove GPU cache usage from clip mask instances. r=kvark,jnicol

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/78f75a74c554