If the current search mode engine is removed, search mode should be cleared
Categories
(Firefox :: Address Bar, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | verified |
People
(Reporter: adw, Assigned: bugzilla)
References
Details
Attachments
(1 file)
It's possible for the user to remove the engine that's currently used in search mode. We should probably clear search mode in that case -- at least it should no longer use the removed engine.
|
||
Comment 1•4 years ago
|
||
And this should be fixed per tab. One possible mistake we could make here would be to just set searchMode to null, though once search mode is retained per tab, when going back to a tab we may risk to enter search mode with an invalid engine. Likely when entering search mode we should check the engine is valid, in addition to exiting it for the current tab.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/af47bc7c002d Exit search mode if the current search mode engine is removed. r=adw
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
|
||
Comment 5•4 years ago
|
||
If a tab is in search mode with a search engine, then I remove that search engine the tab remains in the search mode.
Is this intended?
|
|
Assignee | |
Comment 6•4 years ago
|
||
No, that's not intended. Can you please check that you're using the latest Nightly and provide a screen recording? Search mode is cleared when an engine is removed on my machine.
|
|
||
Comment 7•4 years ago
|
||
With the today's nightly I can not reproduce this issue anymore.
Description
•