Closed Bug 1657831 Opened 4 years ago Closed 4 years ago

Clear Recent History no longer works

Categories

(Thunderbird :: General, defect)

defect

Tracking

(thunderbird_esr78 fixed, thunderbird80 verified)

VERIFIED FIXED
81 Branch
Tracking Status
thunderbird_esr78 --- fixed
thunderbird80 --- verified

People

(Reporter: mark_needham, Assigned: Paenglab)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [TM:78.2.0])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:80.0) Gecko/20100101 Firefox/80.0

Steps to reproduce:

Thunderbird - 80.0b1 - 20200801235059

Attempting to clear history, Using Ctrl+Shift+Delete or Tools > Clear Recent History etc, after choosing options, Clear Now button not active.

Actual results:

Clear Now button not active after choosing options, History not cleared,.

Also, options chosen not retained

Expected results:

Clear Recent History should function as in previous version.

Confirmed using 80.0b1 on Ubuntu 18.0.4.

Status: UNCONFIRMED → NEW
Component: Untriaged → General
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → All
Whiteboard: [TM:78.2.0]

I missed ID selectors when removing the collapseable list in bug 1655080.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9168916 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9168916 [details] [diff] [review]
1657831-fix-sanitizeItemList-selector.patch

Review of attachment 9168916 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin
Attachment #9168916 - Flags: review?(mkmelin+mozilla) → review+
Target Milestone: --- → 81 Branch

Comment on attachment 9168916 [details] [diff] [review]
1657831-fix-sanitizeItemList-selector.patch

[Approval Request Comment]
Regression caused by (bug #): 1655080, is already on beta
User impact if declined: not working sanitize dialog
Testing completed (on c-c, etc.): soon on c-c
Risk to taking this patch (and alternatives if risky): should be low

Attachment #9168916 - Flags: approval-comm-esr78?
Attachment #9168916 - Flags: approval-comm-beta?

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/5fad181c7859
Fix the selector in sanitizeItemList after the changes in bug 1655080. r=mkmelin DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Comment on attachment 9168916 [details] [diff] [review]
1657831-fix-sanitizeItemList-selector.patch

[Triage Comment]
Approved for beta

Attachment #9168916 - Flags: approval-comm-beta? → approval-comm-beta+

Working for me in testing the 80.0b3 release candidate on Ubuntu 18.04.4 LTS.

Can also confirm issue fixed using Thunderbird - 80.0b3 - 20200810231033 on Win 10 Pro x64 - 19041.450

thank you All

Comment on attachment 9168916 [details] [diff] [review]
1657831-fix-sanitizeItemList-selector.patch

[Triage Comment]
Approved for esr78

Attachment #9168916 - Flags: approval-comm-esr78? → approval-comm-esr78+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: