1657894 - Filtering in OpenPGP key manager is broken

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert (:KaiE:)]

Open the OpenPGP key manager.
Type a search entry into the upper area text field and hit enter.

Actual results:
The window closes.
The error console says:

TypeError: document.getElementById(...) is null 2 enigmailKeyManager.js:1702:14
    getFilteredKeys chrome://openpgp/content/ui/enigmailKeyManager.js:1702
    applyFilter chrome://openpgp/content/ui/enigmailKeyManager.js:1793
    applyFilter chrome://openpgp/content/ui/enigmailKeyManager.js:1128
    applyAction chrome://openpgp/content/modules/searchCallback.jsm:35
    value chrome://openpgp/content/modules/searchCallback.jsm:64
    callbackWrapper chrome://openpgp/content/modules/timer.jsm:30
    notify resource://gre/modules/Timer.jsm:62

TypeError: document.getElementById(...) is null enigmailKeyManager.js:1702:14
    getFilteredKeys chrome://openpgp/content/ui/enigmailKeyManager.js:1702
    applyFilter chrome://openpgp/content/ui/enigmailKeyManager.js:1793
    applyFilter chrome://openpgp/content/ui/enigmailKeyManager.js:1128
    applyAction chrome://openpgp/content/modules/searchCallback.jsm:35
    applyActionImmediately chrome://openpgp/content/modules/searchCallback.jsm:31
    setup chrome://openpgp/content/modules/searchCallback.jsm:55

Expected results:
Windows remains open.
List contents are updated to show matches, only.

Comment 1

[Kai Engert (:KaiE:)]

can be reproduced with 78.1.0 and 78.1.1

Comment 2

[Kai Engert (:KaiE:)]

Element emptyTree was removed in 1652537, but there is still code that attempts to access it.

Comment 3

[Kai Engert (:KaiE:)]

Attachment: Bug 1657894 - Filtering in OpenPGP key manager is broken. r=aleca

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/de1f3fb8fe2a
Filtering in OpenPGP key manager is broken. r=aleca DONTBUILD

Comment 5

[Kai Engert (:KaiE:)]

Comment on attachment 9168769 [details]
Bug 1657894 - Filtering in OpenPGP key manager is broken. r=aleca

OpenPGP UI correctness, no risk

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9168769 [details]
Bug 1657894 - Filtering in OpenPGP key manager is broken. r=aleca

[Triage Comment]
Approved for beta

Approved for esr78

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 80.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/d21d722aa77b

Comment 8

[Kai Engert (:KaiE:)]

https://hg.mozilla.org/releases/comm-esr78/rev/523dfa624b0768a7ebf9d12c5960556cff5b73b2