1657983 - Make dom/tests/mochitest/general/test_framedhistoryframes.html to pass on Fission

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect, P3)

Comment 1

[Chris Peterson [:cpeterson]]

Session history blocks our Nightly experiment so tracking session history test failures for Fission Nightly milestone M6b.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia)]

./mach mochitest --setpref="fission.sessionHistoryInParent=true" --enable-xorigin-tests --enable-fission ./dom/tests/mochitest/general/test_framedhistoryframes.html yields:

 0:49.59 TEST_START: http://mochi.test:8888/tests/dom/tests/mochitest/general/test_framedhistoryframes.html
 0:49.80 GECKO(19115) [Parent 19115, Main Thread] WARNING: Transparent mode not supported on non-popup windows.: file /home/mirko/src/firefox/gecko2/widget/gtk/nsWindow.cpp, line 5225
 0:50.12 GECKO(19115) [Parent 19115, Main Thread] WARNING: Transparent mode not supported on non-popup windows.: file /home/mirko/src/firefox/gecko2/widget/gtk/nsWindow.cpp, line 5225
 0:50.80 GECKO(19115) [Parent 19115, Main Thread] WARNING: Transparent mode not supported on non-popup windows.: file /home/mirko/src/firefox/gecko2/widget/gtk/nsWindow.cpp, line 5225
 0:50.99 GECKO(19115) [Parent 19115, Main Thread] WARNING: Transparent mode not supported on non-popup windows.: file /home/mirko/src/firefox/gecko2/widget/gtk/nsWindow.cpp, line 5225
 0:51.37 GECKO(19115) [Parent 19115, Main Thread] WARNING: Transparent mode not supported on non-popup windows.: file /home/mirko/src/firefox/gecko2/widget/gtk/nsWindow.cpp, line 5225
 0:53.03 GECKO(19115) [Parent 19115, Main Thread] WARNING: Transparent mode not supported on non-popup windows.: file /home/mirko/src/firefox/gecko2/widget/gtk/nsWindow.cpp, line 5225
 0:53.98 GECKO(19115) [Child 19279, Main Thread] WARNING: NS_ENSURE_TRUE(mRequest) failed: file /home/mirko/src/firefox/gecko2/netwerk/base/nsBaseChannel.cpp, line 925
 0:54.12 GECKO(19115) [Child 19332, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp, line 241
 0:55.07 GECKO(19115) [Parent 19115, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp, line 407
 0:55.13 GECKO(19115) [19448, Unnamed thread 7fb92608b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:55.13 GECKO(19115) ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpo8Ryi2.mozrunner/runtests_leaks.log
 0:55.13 GECKO(19115) [19448, Unnamed thread 7fb92608b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp, line 202
 0:55.13 GECKO(19115) [19448, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /home/mirko/src/firefox/gecko2/tools/profiler/core/platform.cpp, line 246
 0:55.27 GECKO(19115) [Child 19332, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp, line 241
 0:55.68 GECKO(19115) [Child 19332, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp, line 241
 0:57.17 PASS URL should be correct
 0:57.19 GECKO(19115) [Child 19332, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp, line 241
 0:57.19 PASS Page should be correct
 0:57.35 PASS URL should be correct
 0:57.37 PASS Page should be correct
 0:57.38 GECKO(19115) Assertion failure: mRawPtr != nullptr (You can't dereference a NULL nsCOMPtr with operator->().), at /home/mirko/src/firefox/gecko2/xpcom/base/nsCOMPtr.h:872
Initializing stack-fixing for the first stack frame, this may take a while...

Hence, not a problem in the test-code, but a bug in Gecko.

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia)]

shistory in ChildSHistory::Go is nullptr. Supposedly, this will be fixed in bug 1662410.

Comment 4

[Jens Stutte [:jstutte]]

Hi Neha, this blocks bug 1652554 which is marked M6b. Should we detach it from there?

Comment 5

[Andreas Farre [:farre]]

With the fix for bug 1662410 this doesn't crash, but it doesn't finish.

Comment 6

[Neha Kochar [:neha]]

(In reply to Jens Stutte [:jstutte] (REO for FF 81) from comment #4)

Hi Neha, this blocks bug 1652554 which is marked M6b. Should we detach it from there?

Same as Bug 1657982 Comment 4.

Comment 7

[Neha Kochar [:neha]]

Although the dependency is on the fix of bug 1662410, it really won't take effect with fission until session history pref is enabled with fission (bug fission-history-m6b).

Comment 8

[Mirko Brodesser (:mbrodesser-Igalia)]

 0:46.34 TEST_START: http://mochi.test:8888/tests/dom/tests/mochitest/general/test_framedhistoryframes.html
 0:48.59 GECKO(4901) [Child 5071, Main Thread] WARNING: NS_ENSURE_TRUE(mRequest) failed: file /home/mirko/src/firefox/gecko2/netwerk/base/nsBaseChannel.cpp:928
 0:49.87 GECKO(4901) [Parent 4901, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503
 0:50.73 GECKO(4901) [5240, Unnamed thread 7f1c36c8b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp:202
 0:50.73 GECKO(4901) ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpy9t1uo_w.mozrunner/runtests_leaks.log
 0:50.73 GECKO(4901) [5240, Unnamed thread 7f1c36c8b4c0] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mirko/src/firefox/gecko2/xpcom/base/nsTraceRefcnt.cpp:202
 0:50.73 GECKO(4901) [5240, Main Thread] WARNING: XPCOM_MEM_BLOAT_LOG is set, disabling native allocations.: file /home/mirko/src/firefox/gecko2/tools/profiler/core/platform.cpp:247
 0:52.63 GECKO(4901) [Child 5127, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp:240
 0:53.02 GECKO(4901) [Child 5127, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp:240
 0:53.24 GECKO(4901) [Child 5127, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp:240
 0:53.44 PASS URL should be correct
 0:53.45 GECKO(4901) [Child 5127, Main Thread] WARNING: '!topWindow', file /home/mirko/src/firefox/gecko2/dom/html/HTMLIFrameElement.cpp:240
 0:53.45 PASS Page should be correct
 0:53.62 PASS URL should be correct
 0:53.65 PASS Page should be correct
 0:54.66 GECKO(4901) [Parent 4901, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503
 0:54.66 GECKO(4901) [Parent 4901, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503
 0:54.67 GECKO(4901) [Parent 4901, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503
 0:54.67 GECKO(4901) [Parent 4901, Main Thread] WARNING: Not implemented in the parent process!: file /home/mirko/src/firefox/gecko2/docshell/shistory/SessionHistoryEntry.cpp:503

Test doesn't finish.

Comment 9

[Peter Van der Beken [:peterv]]

This passes for me with fission enabled.

Comment 10

[Mirko Brodesser (:mbrodesser-Igalia)]

(In reply to Peter Van der Beken [:peterv] from comment #9)

This passes for me with fission enabled.

Same here. Will enable it.

Comment 11

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: Bug 1657983: enable "dom/tests/mochitest/general/test_framedhistoryframes.html" for Fission. r=peterv

Locally it passes and finishes now.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24fff0b4a702
enable "dom/tests/mochitest/general/test_framedhistoryframes.html" for Fission. r=peterv

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/24fff0b4a702