Closed
Bug 1658048
Opened 5 years ago
Closed 5 years ago
Remove unused array buffer utilities
Categories
(Chat Core :: General, task)
Chat Core
General
Tracking
(thunderbird_esr78 unaffected)
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| thunderbird_esr78 | --- | unaffected |
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file, 1 obsolete file)
|
15.77 KB,
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
I believe the Skype code (bug 1648197) was the last user of this.
Anyway, we don't support any binary chat protocols anymore, so we don't need this code. (I think there's also better utilities to do some of these things now.)
I also cleaned up the socket code to remove the ability to send binary data. I think this was last used by the Yahoo protocol (bug 1316000). If we ever wanted this again we should really implement this as two separate sub-classes of socket (one for text, one for binary).
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #9168921 -
Flags: review?(khushil324)
|
|
Assignee | |
Comment 2•5 years ago
|
||
I failed to run eslint on the first version of this.
Attachment #9168921 -
Attachment is obsolete: true
Attachment #9168921 -
Flags: review?(khushil324)
Attachment #9168927 -
Flags: review?(khushil324)
|
||
Comment 3•5 years ago
|
||
Comment on attachment 9168927 [details] [diff] [review]
Patch v1.1
Review of attachment 9168927 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me. r=khushil
Attachment #9168927 -
Flags: review?(khushil324) → review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed-tb
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/b77dd3965f8c
Remove obsolete array buffer utilities for chat code. r=khushil
|
|
Assignee | |
Updated•5 years ago
|
Target Milestone: --- → 81 Branch
|
||
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•