1658160 - Assertion failure: get() (dereferencing a UniquePtr containing nullptr), at dist/include/mozilla/UniquePtr.h:281

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

evalInWorker('registerModule("a", parseModule(""));');

Compiled using GCC 9.3.0 and Clang 9 with:

AR=ar sh ./configure --enable-debug --with-ccache --enable-gczeal --enable-debug-symbols --disable-tests

Run with:

-fuzzing-safe --ion-offthread-compile=off --ion-eager

Tested on m-c rev fa0dbdf15f29.

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/2f8d79b33e8a
user:        Jon Coppeard
date:        Thu Aug 06 14:21:34 2020 +0000
summary:     Bug 1655455 - Replace setModuleResolveHook() with registerModule() test function r=jandem

Jon, is bug 1655455 a likely regressor? I doubt this is s-s but setting it just-in-case the assertion failure message sounds bad.

Comment 1

[Christian Holler (:decoder)]

This is not s-s and a fuzzblocker caused by the recently added testing function registerModule which blew up our fuzzing as well over the weekend. :jonco mentioned that he is on PTO on Monday but :sfink might be able to look into it to unblock.

Comment 2

[Steve Fink [:sfink] [:s:]]

The problem is that shell workers do not have a module loader. I'm not sure if workers aren't supposed to use modules, or whether it's just a matter of creating a loader for them. I'll try doing the latter.

Comment 3

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Set release status flags based on info from the regressing bug 1655455

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1658160 - Give shell workers a module loader

Comment 5

[Jon Coppeard (:jonco)]

Looks like Steve has got this.

Comment 6

[Andrew McCreight [:mccr8]]

shell-only

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/8b3429b0e8da
Give shell workers a module loader r=jonco

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/8b3429b0e8da