Closed
Bug 1658225
Opened 4 years ago
Closed 4 years ago
we still get WidgetWheelEvents with 0 delta from PinchGestureInput::ToWidgetWheelEvent on Windows
Categories
(Core :: Panning and Zooming, defect, P3)
Core
Panning and Zooming
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: tnikkel, Assigned: tnikkel)
References
Details
Attachments
(1 file)
Bug 1648489 was supposed to fix this, and it did for most cases, but it can still happen.
|
Assignee | |
Comment 1•4 years ago
|
||
See bug 1648489 for why we need this.
If we don't send a pinch we don't want to update the last scale so that when we do send an event it incorporates the full scale change from the last time we sent an event.
Even if aScale != mLastScale in SendPinch the computed deltaY ( = 100 * (aScale-mLastScale) * widgetscale) can be 0 seemingly because of floating point weirdness I guess.
Depends on D86495
|
||
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P3
Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bf72f2e5024b Ensure that WidgetWheelEvents produced from PinchGestureInputs always have a non-zero deltaY. r=kats
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•