Closed
Bug 1658258
Opened 6 years ago
Closed 6 years ago
Don't pipe target "newSource" event through "source-updated"
Categories
(DevTools :: Framework, task, P3)
DevTools
Framework
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
In target-mixing, once the thread is attached, we set an event listener on the newSource event emitted by the target, and the callback simply emit another event, source-updated (https://searchfox.org/mozilla-central/rev/e07d5eb5646b40b10df3164e315d4a3108cf9101/devtools/client/fronts/targets/target-mixin.js#491,500-503)
we should be able to remove this and directly listen for source-updated in consumer code.
|
Assignee | |
Comment 1•6 years ago
|
||
newSource is emitted on the thread, and it's easier for consumers to listen for an event on the target, since the threadFront might not exist (until it's attached)
Closing the bug (and taking a coffee 😴)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•