1658270 - Optimise testing functions in Cache and Warp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1658270 - Part 1: Optimise "bailout" testing function in CacheIR and Warp. r=jandem!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1658270 - Part 2: Optimise "assertFloat32" testing function in CacheIR and Warp. r=jandem!

This is currently a NOP until bug 1655773 has been implemented.

Depends on D86526

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1658270 - Part 3: Optimise "assertRecoveredOnBailout" testing function in CacheIR and Warp. r=jandem!

WarpCacheIRTranspiler::emitAssertRecoveredOnBailoutResult() was copied from the
MCallOptimize implementation. A new addEffectfulUnsafe() helper was added to
avoid triggering the safety assertions in addEffectful(). The MResumePoint
also needs to be created manually to avoid triggering assertions in the
WarpCacheIRTranspiler::resumeAfter() helper. Bypassing the safety assertions
should be okay in this case, because assertRecoveredOnBailout() is a fuzzy
unsafe testing function, so we can directly control how it is called.

JIT tests which don't (yet) pass in Warp have been disabled and annotated
with "TODO(Warp)".

Drive-by change:

• Use add() in WarpCacheIRTranspiler::addDataViewData().

Depends on D86527

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/39731b445885
Part 1: Optimise "bailout" testing function in CacheIR and Warp. r=jandem
https://hg.mozilla.org/integration/autoland/rev/508fbac0215e
Part 2: Optimise "assertFloat32" testing function in CacheIR and Warp. r=jandem
https://hg.mozilla.org/integration/autoland/rev/bbdd9a249156
Part 3: Optimise "assertRecoveredOnBailout" testing function in CacheIR and Warp. r=jandem

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/39731b445885
https://hg.mozilla.org/mozilla-central/rev/508fbac0215e
https://hg.mozilla.org/mozilla-central/rev/bbdd9a249156