1658313 - Update pdf.js to version 2.6.234

Status: RESOLVED FIXED

(Firefox :: PDF Viewer, task)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1657400 +++

Changes since last update:
#12172 Fix the type definition of TypedArray. (PR 12156 follow-up)
#12174 Do the AppOptions.get("printResolution") lookup once in web/app.js, when initializing PDFPrintServiceFactory-instances, rather than for every printed page
#12173 [api-minor] Fix the annotationStorage parameter in PDFPageProxy.render
#12179 Add support for Object.fromEntries
#12169 Extract common methods from PDFOutlineViewer/PDFAttachmentViewer into a new abstract BaseTreeViewer class
#12175 Support textfield and choice widgets for printing
#12182 Fix the type of PDFDocumentLoadingTask.destroy.
#12154 [api-minor] Allow loading pdf fonts into another document.
#12187 Add a test-case for issue 4398
#12188 Update packages and translations
#12176 Support multiline textfields for printing
#12177 Support comb textfields for printing

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1658313 - Update pdf.js to version 2.6.234. r=bdahl

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62990ef4ea78
Update pdf.js to version 2.6.234. r=bdahl

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 62990ef4ea78 (Bug 1658313) for causing bc failures in browser_pdfjs_navigation.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/51b465c34f8aca7ed48752788546177ad15da28f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=62990ef4ea78c3e957f85d38bae64fe97be329fd&selectedTaskRun=fILxthPQQ_CMPHWVPLgRQA.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312793452&repo=autoland&lineNumber=5634

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I'm having a hard time seeing what the actual exception is here. Brendan, are you able to maybe get more info locally?

Comment 5

[Jonas Jenwald [:Snuffleupagus]]

Attachment: treeItem.diff

Comment 6

[Jonas Jenwald [:Snuffleupagus]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)

I'm having a hard time seeing what the actual exception is here. Brendan, are you able to maybe get more info locally?

This is fallout from upstream re-factoring work, and I just didn't think to check if the mozilla-central tests depended on the renamed CSS rules; sorry about this!

The diff above seems to fix the test, at least locally, for me.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

You rock, thanks Jonas!

Comment 8

[Brendan Dahl [:bdahl] (84 regression triage)]

Attachment: Bug 1658313 - Fix pdf.js outline navigation test. r=ryanvm

• CSS classes for the outline items have changed.
• Add reject reason to make test failure easier to figure out.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9c200eb985b
Update pdf.js to version 2.6.234. r=bdahl
https://hg.mozilla.org/integration/autoland/rev/805d82299d4b
Fix pdf.js outline navigation test. r=RyanVM

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a9c200eb985b
https://hg.mozilla.org/mozilla-central/rev/805d82299d4b