Closed Bug 1658313 Opened 6 months ago Closed 5 months ago

Update pdf.js to version 2.6.234

Categories

(Firefox :: PDF Viewer, task)

task
Not set
normal

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

+++ This bug was initially created as a clone of Bug #1657400 +++

Changes since last update:
#12172 Fix the type definition of TypedArray. (PR 12156 follow-up)
#12174 Do the AppOptions.get("printResolution") lookup once in web/app.js, when initializing PDFPrintServiceFactory-instances, rather than for every printed page
#12173 [api-minor] Fix the annotationStorage parameter in PDFPageProxy.render
#12179 Add support for Object.fromEntries
#12169 Extract common methods from PDFOutlineViewer/PDFAttachmentViewer into a new abstract BaseTreeViewer class
#12175 Support textfield and choice widgets for printing
#12182 Fix the type of PDFDocumentLoadingTask.destroy.
#12154 [api-minor] Allow loading pdf fonts into another document.
#12187 Add a test-case for issue 4398
#12188 Update packages and translations
#12176 Support multiline textfields for printing
#12177 Support comb textfields for printing

Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62990ef4ea78
Update pdf.js to version 2.6.234. r=bdahl

I'm having a hard time seeing what the actual exception is here. Brendan, are you able to maybe get more info locally?

Flags: needinfo?(ryanvm) → needinfo?(bdahl)
Attached patch treeItem.diff (obsolete) — Splinter Review

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)

I'm having a hard time seeing what the actual exception is here. Brendan, are you able to maybe get more info locally?

This is fallout from upstream re-factoring work, and I just didn't think to check if the mozilla-central tests depended on the renamed CSS rules; sorry about this!

The diff above seems to fix the test, at least locally, for me.

Flags: needinfo?(bdahl)

You rock, thanks Jonas!

  • CSS classes for the outline items have changed.
  • Add reject reason to make test failure easier to figure out.
Attachment #9169638 - Attachment is obsolete: true
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9c200eb985b
Update pdf.js to version 2.6.234. r=bdahl
https://hg.mozilla.org/integration/autoland/rev/805d82299d4b
Fix pdf.js outline navigation test. r=RyanVM
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.