Closed Bug 1658321 Opened 4 years ago Closed 4 years ago

socorro deploy: 2020.08.10

Categories

(Socorro :: Infra, task, P1)

Product:
Socorro
Component:
Infra
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

We want to do a deploy for socorro tagged 2020.08.10.

It consists of the following:

90e0d6b: Update FennecAndroid.json to 68.11.0 (pascalchevrel)
c16b971: bug 1649810: upgrade to python 3.8.5 (willkg)
6d9f7e3: Modify Fenix feature versions (rocketsroger)
5107d66: Bump boto3 from 1.14.14 to 1.14.33 (from PR #5497) (dependabot-preview[bot])
24692b2: Bump regex from 2020.6.8 to 2020.7.14 (from PR #5498) (dependabot-preview[bot])
138a413: Bump urllib3 from 1.25.9 to 1.25.10 (from PR #5499) (dependabot-preview[bot])
180f746: Bump botocore from 1.17.20 to 1.17.33 (from PR #5500) (dependabot-preview[bot])
e55c606: Bump sphinx from 3.1.1 to 3.1.2 (from PR #5501) (dependabot-preview[bot])
54cd549: Bump lxml from 4.5.1 to 4.5.2 (from PR #5502) (dependabot-preview[bot])
7b75455: Bump pytest from 5.4.3 to 6.0.1 (from PR #5503) (dependabot-preview[bot])
068e44e: Bump typing from 3.7.4.1 to 3.7.4.3 (from PR #5504) (dependabot-preview[bot])
77e185e: Bump python-jose from 3.1.0 to 3.2.0 (from PR #5505) (dependabot-preview[bot])
2d72fbb: Bump cryptography from 2.9.2 to 3.0 (from PR #5506) (dependabot-preview[bot])
1fbdbc6: Bump django-ratelimit from 3.0.0 to 3.0.1 (from PR #5507) (dependabot-preview[bot])
d0324da: Bump cfn-lint from 0.33.2 to 0.34.0 (from PR #5508) (dependabot-preview[bot])
3267447: Bump asn1crypto from 1.3.0 to 1.4.0 (from PR #5509) (dependabot-preview[bot])
fa280d8: Bump datadog from 0.37.1 to 0.38.0 (from PR #5510) (dependabot-preview[bot])
17a4a63: Bump cffi from 1.14.0 to 1.14.1 (from PR #5511) (dependabot-preview[bot])
eca3c46: Bump awscli from 1.18.97 to 1.18.110 (from PR #5512) (dependabot-preview[bot])
6b4b543: Bump sentry-sdk from 0.15.1 to 0.16.2 (from PR #5513) (dependabot-preview[bot])
b60f140: Bump python from a3ddbd9 to 9c84459 in /docker (from PR #5514) (dependabot-preview[bot])
a577727: Add iniconfig to requirements (willkg)
cb14fe0: Update docs image to 3.8.5 (willkg)
944855e: Fix sentry handling test (willkg)
82ec8d5: Bump sentry-sdk from 0.16.2 to 0.16.3 (dependabot-preview[bot])
f836ea1: Update active vesions (kbrosnan)
23d50b5: Modify Fenix feature versions (rocketsroger)
279c456: bug 1657668: redo product support (willkg)
70e2afb: bug 1657668: get rid of DEFAULT_PRODUCT (willkg)
6be1874: bug 1558916: fix issues with featured versions calculation (willkg)
bac6035: Fix home page title (willkg)
4ad9b17: bug 1657668: improve product_details README (willkg)

This is a P1 because I screwed up and pushed something to stage that affects prod, too. We have a limited amount of time before the cache in prod expires and then prod starts throwing errors in the Crash Stats web site.

I verified the latest round of changes on stage and everything else has been sitting on stage for a week.

Tagged:

tag 2020.08.10
Tagger: Will Kahn-Greene <willkg@mozilla.com>
Date:   Mon Aug 10 11:09:53 2020 -0400

`90e0d6b`: Update FennecAndroid.json to 68.11.0 (pascalchevrel)
`c16b971`: bug 1649810: upgrade to python 3.8.5 (willkg)
`6d9f7e3`: Modify Fenix feature versions (rocketsroger)
`5107d66`: Bump boto3 from 1.14.14 to 1.14.33 (from PR #5497) (dependabot-preview[bot])
`24692b2`: Bump regex from 2020.6.8 to 2020.7.14 (from PR #5498) (dependabot-preview[bot])
`138a413`: Bump urllib3 from 1.25.9 to 1.25.10 (from PR #5499) (dependabot-preview[bot])
`180f746`: Bump botocore from 1.17.20 to 1.17.33 (from PR #5500) (dependabot-preview[bot])
`e55c606`: Bump sphinx from 3.1.1 to 3.1.2 (from PR #5501) (dependabot-preview[bot])
`54cd549`: Bump lxml from 4.5.1 to 4.5.2 (from PR #5502) (dependabot-preview[bot])
`7b75455`: Bump pytest from 5.4.3 to 6.0.1 (from PR #5503) (dependabot-preview[bot])
`068e44e`: Bump typing from 3.7.4.1 to 3.7.4.3 (from PR #5504) (dependabot-preview[bot])
`77e185e`: Bump python-jose from 3.1.0 to 3.2.0 (from PR #5505) (dependabot-preview[bot])
`2d72fbb`: Bump cryptography from 2.9.2 to 3.0 (from PR #5506) (dependabot-preview[bot])
`1fbdbc6`: Bump django-ratelimit from 3.0.0 to 3.0.1 (from PR #5507) (dependabot-preview[bot])
`d0324da`: Bump cfn-lint from 0.33.2 to 0.34.0 (from PR #5508) (dependabot-preview[bot])
`3267447`: Bump asn1crypto from 1.3.0 to 1.4.0 (from PR #5509) (dependabot-preview[bot])
`fa280d8`: Bump datadog from 0.37.1 to 0.38.0 (from PR #5510) (dependabot-preview[bot])
`17a4a63`: Bump cffi from 1.14.0 to 1.14.1 (from PR #5511) (dependabot-preview[bot])
`eca3c46`: Bump awscli from 1.18.97 to 1.18.110 (from PR #5512) (dependabot-preview[bot])
`6b4b543`: Bump sentry-sdk from 0.15.1 to 0.16.2 (from PR #5513) (dependabot-preview[bot])
`b60f140`: Bump python from `a3ddbd9` to `9c84459` in /docker (from PR #5514) (dependabot-preview[bot])
`a577727`: Add iniconfig to requirements (willkg)
`cb14fe0`: Update docs image to 3.8.5 (willkg)
`944855e`: Fix sentry handling test (willkg)
`82ec8d5`: Bump sentry-sdk from 0.16.2 to 0.16.3 (dependabot-preview[bot])
`f836ea1`: Update active vesions (kbrosnan)
`23d50b5`: Modify Fenix feature versions (rocketsroger)
`279c456`: bug 1657668: redo product support (willkg)
`70e2afb`: bug 1657668: get rid of DEFAULT_PRODUCT (willkg)
`6be1874`: bug 1558916: fix issues with featured versions calculation (willkg)
`bac6035`: Fix home page title (willkg)
`4ad9b17`: bug 1657668: improve product_details README (willkg)

Deploy bug #1658321
-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEzY3I6/E2Vh8o9nPoGL3RpvBm7BEFAl8xY0EACgkQGL3RpvBm
7BEuHwf/b9A9XiFDrsvbU+p1fXXtxginxjkfmV2XbR4HGSim0bNOLLWvLzd8y4jL
Y/Oke1w+VJIETMYo9BR0Zdca7ifN7Jrpwj8of554i68BuLQ3XOVYZ6/5NEPc7DkE
/XYauEbM53ePq5JKrUmFdGXGNguptKEVOYnJ6A4RyuZl8jKBKlDa1FzVjvJgjK1q
T+TfE/hN7F4RywYRuuj4yXHqHexCS3oVlI9acm85dJYo2eRiRwp/31edbFHTFMt+
14WUxCJzx5GGl3jFWhAsUFQCmjALHPuRBubzeXK/Yo1hLxSd3ic59vspcNjCBgdT
fn4TblkkFtixsfRlANQUlCY7mYD0jA==
=xDmP
-----END PGP SIGNATURE-----

commit 7393c7bbd1e7f592d110c4dd39d913d193a868c1 (HEAD -> main, tag: 2020.08.10, official/main)
Merge: 6c57da74c 4ad9b1706
Author: Will Kahn-Greene <willkg@users.noreply.github.com>
Date:   Mon Aug 10 10:37:04 2020 -0400

    Merge pull request #5519 from willkg/1657668-product-support
    
    bug 1657668, 1558916: rework product support

I see 30 error events in Sentry around two problems:

  1. "auth" isn't a valid version (25 events)

    The code looked at the files in the GitHub repo for featured versions. I reworked that and landed the changes such that the code only looked at the local disk and no longer looked at GitHub. However, I also changed the featured versions values in those files. Thus between the time when I landed the changes in the main branch and when we did a prod deploy, the Crash Stats site was throwing errors because there were things in the files it didn't recognize.

    The new code doesn't look at GitHub anymore, so this won't be a problem going forward.

  2. "crashstats_product" doesn't exist (5 events)

    I changed the code so it no longer used the crashstats_product table and wrote a migration to delete the table. Because migrations happen separately from when the webapp comes up, it's possible for the migrations to occur while the old version of the webapp is running.

    This issue is covered in our conventions already--we should be pushing out code changes and db changes separately. I just messed up.

After the deploy finished, the issues went away. The site looks fine in Grafana.

Marking as FIXED.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.