Closed Bug 1658512 Opened 5 years ago Closed 5 years ago

OpenPGP Key Manager: column Key ID cannot be resized

Categories

(MailNews Core :: Security: OpenPGP, defect)

Product:
MailNews Core
Component:
Security: OpenPGP
Type:
defect

Tracking

(thunderbird_esr78 fixed, thunderbird80 fixed)

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- fixed
thunderbird80 --- fixed

People

(Reporter: flo.sammueller, Assigned: flo.sammueller)

Details

Attachments

(2 files, 1 obsolete file)

key_id.png
29.23 KB, image/png
Details
1658512.patch
1.21 KB, patch
mkmelin
: review+
wsmwk
: approval-comm-beta+
wsmwk
: approval-comm-esr78+
Details | Diff | Splinter Review

When viewing the Certifications of a key using the OpenPGP Key Manager, the column Key ID cannot be resized.

Attached patch 1658512.patch (obsolete) — — Splinter Review

It seems to be resizable for me. (Both of the below.)
The "Key ID" column in that main view, or the "ID" column of the details one get when opening a key.

Attached image key_id.png —

This is the view that I meant

Ah, I see that.

Assignee: nobody → flo.sammueller
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 9169377 [details] [diff] [review] 1658512.patch Review of attachment 9169377 [details] [diff] [review]: ----------------------------------------------------------------- This works for me, thx! Could you attach a patch by `hg export` such that it includes the proper header and patch author information? The first line should be something like "Bug 1658512 - make the certifications Key Id column resizable. r=mkmelin"
Attachment #9169377 - Flags: review+
Attached patch 1658512.patch — — Splinter Review

Correct export of patch.

Attachment #9169377 - Attachment is obsolete: true
Comment on attachment 9169431 [details] [diff] [review] 1658512.patch Review of attachment 9169431 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #9169431 - Flags: review+
Keywords: checkin-needed-tb
Target Milestone: --- → 81 Branch

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/3bbde9543946
make the certifications Key Id column resizable. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED

Comment on attachment 9169431 [details] [diff] [review]
1658512.patch

OpenPGP UI glitch fix. No risk

Attachment #9169431 - Flags: approval-comm-esr78?
Attachment #9169431 - Flags: approval-comm-beta?

Comment on attachment 9169431 [details] [diff] [review]
1658512.patch

[Triage Comment]
Approved for beta
Approved for esr78

Attachment #9169431 - Flags: approval-comm-esr78?
Attachment #9169431 - Flags: approval-comm-esr78+
Attachment #9169431 - Flags: approval-comm-beta?
Attachment #9169431 - Flags: approval-comm-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: