1658578 - Refine third-party API

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Dimi Lee [:dimi]]

Right now, we has three different third-party APIs:
ThirdPartyUtil::IsThirdPartyFoo, AntiTrackingUtils:ThirdPartyFoo and nsContentUtils:IsThirdPartyWindowOrChannel

The plan is:
For ThirdPartyUtil::IsThirdPartyFoo, it should consider the whole chain
For AntiTrackingUtils::IsThirdPartyFoo, it should consider top-level.
For anti-tracking project, use AntiTrackingUtils::IsThirdPartyFoo, as for other places in gecko, use ThirdPartyUtil::IsThirdPartyFoo.

So what we need to do is:

1. Make sure the behavior is sync for channel and window for ThirdPartyUtil::IsThirdPartyFoo and AntiTrackingUtils::IsThirdPartyFoo
2. Remove using nsContentUtils:IsThirdPartyWindowOrChannel, replace it with either ThirdPartyUtils or AntiTrackingUtils, depending on the use case (in anti-tracking project or not)
3. Examine the current usage of those third-party APIs, make sure we only use AntiTrackingUtils one in anti-tracking project.

Comment 1

[Johann Hofmann [:johannh]]

Dimi, unassigning you because someone from our team might pick this up. Let me know if you were still working on this.

Comment 2

[Paul Zühlcke [:pbz]]

Attachment: Bug 1658578 - Remove nsContentUtils::IsThirdPartyWindowOrChannel. r=timhuang!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa071b03d212
Remove nsContentUtils::IsThirdPartyWindowOrChannel. r=timhuang

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/aa071b03d212