Closed Bug 1658624 Opened 10 months ago Closed 9 months ago

Search mode indicator design tweaks

Categories

(Firefox :: Address Bar, enhancement, P2)

Product:
Firefox
Component:
Address Bar
Type:
enhancement
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
82 Branch
Iteration:
82.2 - Sep 7 - Sep 20
Tracking Flags:
Tracking Status
firefox82 --- verified

People

(Reporter: harry, Assigned: harry)

References

Details

Attachments

(1 file)

Bug 1658624 - Search mode indicator design tweaks. r?dao!
47 bytes, text/x-phabricator-request
Details | Review

There are a couple of design tweaks required for the search mode indicator. We can catalogue them here, then do them all in one patch. I think we should wait as long as possible before the beta cutoff to allow UX to make any final modifications.

Currently, we need to:

  • Remove the left border on the search mode indicator shown when the Urlbar is collapsed
  • Update indicator colours for dark mode, per the InVision spec
Type: defect → task
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 82.1 - Aug 24 - Sep 6
Type: task → enhancement
Iteration: 82.1 - Aug 24 - Sep 6 → 82.2 - Sep 7 - Sep 20
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b4a1e015ea3e
Search mode indicator design tweaks. r=dao

https://hg.mozilla.org/mozilla-central/rev/b4a1e015ea3e

Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch

I verified this issue using 82.0a1 (2020-09-14) on macOS 10.13 and Windows 10 x64.
Adrian could you help me with Ubuntu verification?

Flags: needinfo?(adrian.florinescu)

Verified as fixed using Firefox 82 beta 1 (with update2 prefs flipped) and latest Nightly 83.0a1 under Ubuntu 18.04 64-bit.

Status: RESOLVED → VERIFIED
status-firefox82: fixed → verified
Flags: needinfo?(adrian.florinescu)
You need to log in before you can comment on or make changes to this bug.