1659010 - UX regressions from visual updates, copies errors, radio disabled

Status: RESOLVED FIXED

(Toolkit :: Printing, defect, P1)

Description

[Mark Striemer [:mstriemer]]

The photon-number component overrides its input's focus state, but it didn't replace the :invalid state. This needs to be added back.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1656939

Comment 3

[Mark Striemer [:mstriemer]]

The radio buttons are also missing a disabled state

Comment 4

[Mark Striemer [:mstriemer]]

Bug 1659184 is handling the copies input, this can just fix the radio buttons disabled state.

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1659010 - Disabled state for print UI radio buttons r?emalysz

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87d6f9aae898
Disabled state for print UI radio buttons r=emalysz

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on browser_startup_mainthreadio.js

backout: https://hg.mozilla.org/integration/autoland/rev/ae1856c03c2b2e5b1ea4e20b9366777c2e1f130a

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=A1rRHWJYRw6spibr9SjHJw.0&revision=87d6f9aae898d6f3f2d61300ec8f78cd4f533192&test_paths=browser%2Fbase%2Fcontent%2Ftest%2Fperformance%2Fio%2Fbrowser.ini

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=313355300&repo=autoland&lineNumber=2437

[task 2020-08-18T20:38:17.089Z] 20:38:17 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_mainthreadio.js | unexpected read on C:\Users\task_1597782246\AppData\Local\Temp\tmpbfjo7s.mozrunner\pkcs11.txt before first paint -
[task 2020-08-18T20:38:17.089Z] 20:38:17 INFO - Stack trace:
[task 2020-08-18T20:38:17.089Z] 20:38:17 INFO - nsNSSComponent::InitializeNSS
[task 2020-08-18T20:38:17.089Z] 20:38:17 INFO - DisplayList building
[task 2020-08-18T20:38:17.089Z] 20:38:17 INFO - nsLayoutUtils::PaintFrame
[task 2020-08-18T20:38:17.089Z] 20:38:17 INFO - PresShell::Paint chrome://browser/content/browser.xhtml
[task 2020-08-18T20:38:17.089Z] 20:38:17 INFO - EventDispatcher::Dispatch MozSVGAsImageDocumentLoad
[task 2020-08-18T20:38:17.090Z] 20:38:17 INFO - EventDispatcher::Dispatch
[task 2020-08-18T20:38:17.090Z] 20:38:17 INFO - XREMain::XRE_main
[task 2020-08-18T20:38:17.090Z] 20:38:17 INFO - (PoisonIOInterposer) read - C:\Users\task_1597782246\AppData\Local\Temp\tmpbfjo7s.mozrunner\pkcs11.txt
[task 2020-08-18T20:38:17.090Z] 20:38:17 INFO - Not taking screenshot here: see the one that was previously logged

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1434cd0e765b
Disabled state for print UI radio buttons r=emalysz a=reland CLOSED TREE

Comment 9

[Natalia Csoregi [:nataliaCs]]

Have relanded this patch as it has not caused the mentioned failures in Comment 7 .
Sorry for the inconvenience caused.

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1434cd0e765b