Closed Bug 1659034 Opened 4 years ago Closed 4 years ago

nsThread should only unregister itself from the profiler if it registered itself

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: mozbugz, Assigned: mozbugz)

References

Details

Attachments

(1 file)

Bug 1659034 - Only call PROFILER_UNREGISTER_THREAD in nsThread::ThreadFunc if PROFILER_REGISTER_THREAD was called before - r?canaltinova
47 bytes, text/x-phabricator-request
Details | Review

nsThread should only call PROFILER_UNREGISTER_THREAD() if it called PROFILER_REGISTER_THREAD() with a non-empty name before.

This is probably not the cause of bug 1657174, which crashes with named threads; but it's the correct thing to do anyway.

Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd100ad06a48
Only call PROFILER_UNREGISTER_THREAD in nsThread::ThreadFunc if PROFILER_REGISTER_THREAD was called before - r=canaltinova

https://hg.mozilla.org/mozilla-central/rev/cd100ad06a48

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: