1659034 - nsThread should only unregister itself from the profiler if it registered itself

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

nsThread should only call PROFILER_UNREGISTER_THREAD() if it called PROFILER_REGISTER_THREAD() with a non-empty name before.

This is probably not the cause of bug 1657174, which crashes with named threads; but it's the correct thing to do anyway.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1659034 - Only call PROFILER_UNREGISTER_THREAD in nsThread::ThreadFunc if PROFILER_REGISTER_THREAD was called before - r?canaltinova

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd100ad06a48
Only call PROFILER_UNREGISTER_THREAD in nsThread::ThreadFunc if PROFILER_REGISTER_THREAD was called before - r=canaltinova

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cd100ad06a48