1659045 - Nightly is not localized after updating to build 20200813213942

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Francesco Lodolo [:flod]]

Using Nightly in Italian. After updating to 20200813213942, my Nightly restarted in English.

I still see Italian packaged, for example if I go to resource:///localization/it/browser/.

About:support relevant pieces

  "intl": {
    "localeService": {
      "requested": [
        "en-US"
      ],
      "available": [
        "en-US"
      ],
      "supported": [
        "en-US"
      ],
      "regionalPrefs": [
        "en-US"
      ],
      "defaultLocale": "en-US"
    },
    "osPrefs": {
      "systemLocales": [
        "it-IT",
        "en-IT"
      ],
      "regionalPrefsLocales": [
        "it-IT",
        "en-IT"
      ]
    }
  },

So, suddenly it's not requesting Italian, and it is not even available in the available locales.

I tried creating a new profile, it's still in English. What's interesting is that the accept-languages is localized, requesting Italian content.

Comment 1

[Francesco Lodolo [:flod]]

[Tracking Requested - why for this release]:

Comment 2

[Francesco Lodolo [:flod]]

Note that updates are currently blocked.

Bug 1656515 just landed, that seems like a possible cause, since it touches intl/locale/LocaleService.cpp.

Comment 3

[Francesco Lodolo [:flod]]

The version previously installed was 20200813092915, based on https://hg.mozilla.org/mozilla-central/rev/32ec11f12a6225412c435cc250491175a7552021

Broken build is based on https://hg.mozilla.org/mozilla-central/rev/f46205a42faecda0e5a73bdcde0a8e1caa0126d9

Regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=32ec11f12a6225412c435cc250491175a7552021&tochange=f46205a42faecda0e5a73bdcde0a8e1caa0126d9

I can't spot anything relevant besides bug 1656515.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1656515 has been backed out and the nightly builds starting at 10:00 UTC will contain the backout.

Comment 5

[Mic Sparrow]

When will you enable Nightly updates?

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Francesco, are you using a single-locale build or langpack? I can't seem to reproduce this here.

I installed 2020-08-13-21-39-42, then a langpack, and it showed up as expected in about:support as an available locale.

Zibi, maybe you have an idea about what could be going wrong?

Comment 7

[Francesco Lodolo [:flod]]

It's a single locale build (repackage?), not build+language pack.

Comment 8

[James Willcox (:snorp) ([e-mail]) (he/him)]

OK, the single-locale build for es-MX seems to work for me. Firefox is in Spanish, and the available locales lists "es-MX, en-US".

Comment 9

[Francesco Lodolo [:flod]]

(In reply to James Willcox (:snorp) ([e-mail]) (he/him) from comment #8)

OK, the single-locale build for es-MX seems to work for me. Firefox is in Spanish, and the available locales lists "es-MX, en-US".

At this point, I honestly have no clue under which condition this happens.

I tried downloading builds from FTP, both es-MX and it, and they are correctly localized
http://archive.mozilla.org/pub/firefox/nightly/2020/08/2020-08-13-09-29-15-mozilla-central-l10n/

My Nightly is still in English at the moment. As I said, it affects even new profiles created from this build.

Comment 10

[Francesco Lodolo [:flod]]

Bear with me, it's Friday and it's been a long week :-(

Single locale builds are in English, I just need to test builds from the right folder
http://archive.mozilla.org/pub/firefox/nightly/2020/08/2020-08-13-21-39-42-mozilla-central-l10n/

Comment 11

[Francesco Lodolo [:flod]]

Also tested 20200814094524, based on 605c404fbd80c67e1127ac054b8bec6742bd748f (which includes the backout), and Nightly is back in Italian.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Francesco Lodolo [:flod] from comment #9)

I tried downloading builds from FTP, both es-MX and it, and they are correctly localized
http://archive.mozilla.org/pub/firefox/nightly/2020/08/2020-08-13-09-29-15-mozilla-central-l10n/
Is that an affected build (yesterday European morning)?

When I download the Win x64 es-MX Nightly from yesterday 10pm UTC:

• tab titles for content in Spanish
• menu bar > Help > About Firefox in Spanish
• hamburger menu in Spanish
• menu bar > Tools > Web developer submenu in Spanish
  Other strings in en-US.
  Content vs. main process?

Today's Nightly shows the profile manager (-P) in es-MX but the application itself still has the language mix (EDIT: only in the menu bar now).

Comment 13

[Zibi Braniecki [:zbraniecki][:gandalf]]

Flod - in the broken build, what is your resource://gre/res/multilocale.txt?

Comment 14

[Francesco Lodolo [:flod]]

I suggest to use it for testing. I need to look into why es-MX has the main menu in English, but I suspect that to be missing strings falling back to English.

(In reply to Zibi Braniecki [:zbraniecki][:gandalf] from comment #13)

Flod - in the broken build, what is your resource://gre/res/multilocale.txt?

it,en-US

Build downloaded from http://archive.mozilla.org/pub/firefox/nightly/2020/08/2020-08-13-21-39-42-mozilla-central-l10n/ and with new profile.

Comment 15

[James Willcox (:snorp) ([e-mail]) (he/him)]

I get the same results with an "it" build. Firefox is in Italian, etc.

Comment 16

[Francesco Lodolo [:flod]]

Just to confirm. I'm on macOS.

1. Download Italian build from FTP here: http://archive.mozilla.org/pub/firefox/nightly/2020/08/2020-08-13-21-39-42-mozilla-central-l10n/
2. Create a new profile. The profile manager itself is already in English, while it should be in Italian.
3. Menus are in English, about:support has only en-US.

I just repeated all the steps from scratch. So, unless you're on a different OS and it's macOS specific, I don't know why we're getting different results.

Comment 17

[Francesco Lodolo [:flod]]

Oh, one more thing. I show the profile manager by default (unchecked the option to start with the default profile). I kind of remember that made a difference in replicating some bugs.

Comment 18

[Zibi Braniecki [:zbraniecki][:gandalf]]

Ok, so seems like the file is correct. My only guess is that the patch in bug 1656515 mangles the strings as we read it. It should be easy to dump it and see if the value after decompression is correct.

Comment 19

[Alex Thayer [:alexical] (she/her)]

Posted what I believe is wrong in bug 1656515. Not sure about the details of how our language stuff works in order to cause this, but the patch from bug 1656515 should work correctly for any resources that are compressed, and incorrectly for resources that are stored decompressed. The default omni.ja on desktop is stored decompressed, but I don't know what the behavior is for language repacks.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

(In reply to Mic Sparrow from comment #5)

When will you enable Nightly updates?

Nightly respins are finished and updates have been re-enabled.

Comment 21

[Mic Sparrow]

Thank you all for your hard work and help.

Comment 22

[Francesco Lodolo [:flod]]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #12)

Today's Nightly shows the profile manager (-P) in es-MX but the application itself still has the language mix (EDIT: only in the menu bar now).

To close the loop, that's bug 1659147 (new FTL loaded on start-up, if missing causes fall back to English).