Closed Bug 1659061 Opened 2 years ago Closed 1 year ago

[wpt-sync] Sync PR 25008 - Replace os.path.split with .dirname or .basename where appropriate

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox82 fixed)

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25008 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25008
Details from upstream follow.

Philip Jägenstedt <philip@foolip.org> wrote:

Replace os.path.split with .dirname or .basename where appropriate

Most of the changes made by:

git grep -lF os.path.split | xargs sed -i '' 's/os.path.split((.*))[0]/os.path.dirname(\1)/g'

That gets some things wrong, so all changes were vetted and some fixed
or simplified.

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 8 tests and 4 subtests

Status Summary

Firefox

OK : 8
PASS : 16

Chrome

OK : 8
PASS : 16

Safari

OK : 7
PASS : 14
FAIL : 1
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d5e389a47637
[wpt PR 25008] - Replace os.path.split with .dirname or .basename where appropriate, a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.