1659121 - Orientation change resets the number of copies to default

Status: VERIFIED FIXED

(Toolkit :: Printing, defect, P2)

Description

[Anca Soncutean, Desktop QA]

Affected versions

• 81.0a1

Affected platforms

• Ubuntu 18.04

Steps to reproduce

1. Launch Firefox
2. Open the new Print modal on any page
3. Increase the numbers of copies
4. Change the Orientation

Expected result

• The numbers of copies stays the same

Actual result

• The number of copies is reset to 1

Regression range

• Not a regression

Additional notes

• Windows and macOS are not affected
• Reproduces both ways, regardless of the initial orientation state

Suggested severity

• I think that S2 is suitable for this issue

Comment 1

[Blake Winton (:bwinton) (:☕️)]

There's an easy workaround available, but it might point to a bigger underlying issue…

Comment 2

[Mark Striemer [:mstriemer]]

I think this is just cause the copies aren't saved to prefs but we're repopulating the input from the settings when settings change. That code [1] can likely be deleted and the value can be initialized to 1 in print.html.

[1] https://searchfox.org/mozilla-central/rev/358cef5d1a87172f23b15e1a705d6f278db4cdad/toolkit/components/printing/content/print.js#404-406

Comment 3

[Anca Soncutean, Desktop QA]

Regression range

• Not a regression

• I have to make a correction here.. This is a regression after all, I've managed to restrain the regression windows to the folowwing: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=74b3be6fcb93aba5e967179e49676f4fb6422851&tochange=f46205a42faecda0e5a73bdcde0a8e1caa0126d92851&tochange=f46205a42faecda0e5a73bdcde0a8e1caa0126d9

• Additional note: I can reproduce the issue also by changing between Fit to page and Scale options.

Comment 4

[Jonathan Kew [:jfkthame]]

(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #0)

• Windows and macOS are not affected

This does reproduce for me on macOS: the Copies field resets to 1 as soon as I toggle the portrait/landscape orientation (or if I change other options: scale, headers & footers, backgrounds).

Comment 5

[Mark Striemer [:mstriemer]]

I'm wondering if this is really bug 1659302. If I type a number in and change the orientation it sticks, but using the spin button it gets reset.

Anca, do you mind checking if that's always the case on your end? These might be different manifestations of the same bug.

Comment 6

[Anca Soncutean, Desktop QA]

(In reply to Mark Striemer [:mstriemer] from comment #5)

I'm wondering if this is really bug 1659302. If I type a number in and change the orientation it sticks, but using the spin button it gets reset.

Anca, do you mind checking if that's always the case on your end? These might be different manifestations of the same bug.

Yes, you are right, manual input doesn't reset for me at any option change attempt, only when using the arrow stepper (Windows 10, macOS 10.15 and Ubuntu 18.04), so the root cause is most likely described by bug 1659302.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

(It sounds like this should be fixed by bug 1659302 so removing the [print2020_v81] whiteboard tag for easier tracking.)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Hi Anca, can you confirm whether this bug is fixed now that bug 1659302 is resolved?

Comment 9

[Anca Soncutean, Desktop QA]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #8)

Hi Anca, can you confirm whether this bug is fixed now that bug 1659302 is resolved?

Yes, I can confirm the fix on Fx 81.0a1 (2020-08-20) across platforms (Windows 10, Ubuntu 18.04 and macOS 10.14).

Comment 10

[Maria Berlinger [:mberlinger], Services QA]

https://testrail.stage.mozaws.net/index.php?/cases/view/1081133