1659150 - Remove about:welcome trailhead, full page and ReturnToAMO templates

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Opening bug to refactor and remove trailhead about:welcome experience.

1. Ensure extended triplets functionality is hidden and can be enabled by pref flip
2. Enterprise builds should be able to turn off firstrun and extended triplets with pref flip

Comment 1

[Nan Jiang [:nanj]]

Let's also remove the custom experiment enrollment ping for Trailhead.

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1659150 - Remove about:welcome trailhead, full page and ReturnToAMO templates

Comment 3

[Punam Dahiya [:pdahiya]]

NI @mkaply to help file bugs to update enterprise policies that rely on trailhead.firstrun.branches pref to override firstrun flow. With this fix in 82, We should turn off first run on-boarding using pref browser.aboutwelcome.enabled. Thanks!

Comment 4

[Mike Kaply [:mkaply]]

I think you could probably do this as part of this patch. Just remove the following lines in Policies.jsm:

https://searchfox.org/mozilla-central/rev/2b250967a66886398e5e798371484fd018d88a22/browser/components/enterprisepolicies/Policies.jsm#570
https://searchfox.org/mozilla-central/rev/2b250967a66886398e5e798371484fd018d88a22/browser/components/enterprisepolicies/Policies.jsm#1318
https://searchfox.org/mozilla-central/rev/2b250967a66886398e5e798371484fd018d88a22/browser/components/enterprisepolicies/Policies.jsm#1986

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08f94ba4c50c
Remove about:welcome trailhead, full page and ReturnToAMO templates r=perftest-reviewers,Mardak,mkaply,nanj,sparky

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for browser chrome failures on browser_all_files_referenced.js.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=08f94ba4c50cb77919eabe8b0708d7c1f9fef1f1&searchStr=Linux%2C18.04%2Cx64%2Copt%2CMochitests%2Ctest-linux1804-64%2Fopt-mochitest-browser-chrome-e10s%2Cbc6&selectedTaskRun=MDDEgS1DR2ybTjRFy78eBw.0

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315407184&repo=autoland&lineNumber=3175

Backout link: https://hg.mozilla.org/integration/autoland/rev/6d91f5b4cc322020443d2789407a3fe0ad50091b

Comment 7

[Punam Dahiya [:pdahiya]]

Fixed test by removing unreferenced file browser/components/newtab/data/content/assets/gift-extension.svg

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47f3048656d3
Remove about:welcome trailhead, full page and ReturnToAMO templates r=perftest-reviewers,Mardak,mkaply,nanj,sparky

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/47f3048656d3

Comment 10

[Robert Martin [:romartin], Ecosystem QA]

I have verified the following using Firefox 82 RC en-US (Build ID: 20201014125134) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:

• The "about:newtab" page without trailhead modal is correctly displayed when navigating to the "about:welcome" page while the "browser.aboutwelcome.enabled" pref is set to "false".
• The "about:newtab" page with the "Dynamic Triplets" is correctly displayed when navigating to the "about:welcome" page while the "browser.aboutwelcome.enabled" pref is set to "false", and the "trailhead.firstrun.newtab.triplets" pref is set to "dynamic".