1659169 - Show custom Return to AMO about:welcome based off attribution

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to complete Return to AMO first run user journey by showing custom about:welcome page

Comment 1

[Punam Dahiya [:pdahiya]]

https://docs.google.com/document/d/1BukJcOsfXoP651IN8P2BTZ8jpc83KAa3caMKlpjTxDQ/edit#heading=h.s8tthpuqlobw

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: Technical Plan for about:welcome RTAMO support in Fx83

Comment 4

[Punam Dahiya [:pdahiya]]

Attachment: Screenshot of RTAMO UX in Fx75.png

Comment 5

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1659169 - RTAMO custom onboarding

Comment 6

[Punam Dahiya [:pdahiya]]

Attachment: Screen Shot for UI review - RTAMO UX in Fx 83

NI Aaron for UI review of implemented RTAMO first run page in Fx 83. Click of Add Extension opens doorhanger to install extension , click of start browsing opens awesome bar. Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f776318df3c6
RTAMO custom onboarding r=fluent-reviewers,Mardak,flod

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f776318df3c6

Comment 9

[Release mgmt bot [:sylvestre / :calixte / :marco for bugbug]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 10

[Peter Van der Beken [:peterv]]

The patch for this bug removed a skip-if = fission annotation from browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js and added a new test (browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js) with a skip-if = fission annotation. I'm going to assume that it was a mistake (not caught by reviewers), please be more careful. If it's not a mistake, please don't add new tests that are disabled for fission when they're added, and please don't reenable tests in an unrelated patch.

Comment 11

[Punam Dahiya [:pdahiya]]

(In reply to Peter Van der Beken [:peterv] from comment #10)

The patch for this bug removed a skip-if = fission annotation from browser/components/newtab/test/browser/browser_aboutwelcome_multistage.js and added a new test (browser/components/newtab/test/browser/browser_aboutwelcome_rtamo.js) with a skip-if = fission annotation. I'm going to assume that it was a mistake (not caught by reviewers), please be more careful. If it's not a mistake, please don't add new tests that are disabled for fission when they're added, and please don't reenable tests in an unrelated patch.

yes, it was mistake. Thanks for catching! We can file a followup fix unless this is getting fixed in another patch.

Comment 12

[Alex Cornestean]

Hello,

Verified the fix using the latest Nightly (84.0a1/20201022215159) and Beta (83.0b3/20201022171613) under Windows 10 Pro 64-bit with the recommended add-on uBlock Origin.

The new RTAMO UI has been properly implemented. Clicking on the “Add the Extension” button will start the extension installation process and clicking on the “Not Now” button will open the Awesome Bar for browsing. See the attached screenshots for more details.

Comment 13

[Alex Cornestean]

Attachment: RTAMO Nightly.png

Comment 14

[Alex Cornestean]

Attachment: RTAMO Beta.png