Closed Bug 1659184 Opened 4 years ago Closed 4 years ago

Replace photon-number component with input[type=number] styles

Categories

(Toolkit :: Themes, task)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: ntim, Assigned: mstriemer)

References

(Regressed 1 open bug)

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/50cb0892948fb4291b9a6b1b30122100ec7d4ef2/toolkit/components/printing/content/photon-number.css

https://searchfox.org/mozilla-central/rev/50cb0892948fb4291b9a6b1b30122100ec7d4ef2/toolkit/components/printing/content/print.js#398-449

Figuring out styles are a bit more complex than figuring out the photon-number CE since pseudo elements have some default styles, but it's worth it for pages using common.css and to not re-invent a11y (aria-hidden isn't in the CE for the buttons)/markup/styles of input[type=number].

Here's how input[type=number] is structured:

input[type=number]
  ::-moz-complex-control-wrapper
    ::-moz-text-control-editing-root
    ::-moz-number-spin-box
      ::-moz-number-spin-up
      ::-moz-number-spin-down
Assignee: nobody → mstriemer
Status: NEW → ASSIGNED
Blocks: 1659302
Summary: Replace photon-number component with common.css input[type=number] styles → Replace photon-number component with input[type=number] styles
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2f26a86b17c
Replace photon-number with pseudo-elements r=ntim,jaws
Blocks: 1659121
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Regressions: 1670912
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: