Closed Bug 1659317 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25027 - Misc bug fixes/features for webcodecs/VideoEncoder

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox82 fixed)

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25027 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25027
Details from upstream follow.

Chris Cunningham <chcunningham@chromium.org> wrote:

Misc bug fixes/features for webcodecs/VideoEncoder

  • don't clear the error callback prior to calling it
  • implement encodeQueueSize to signal backpressure
  • add extra error logging for VpxVideoEncoder
  • disable vp9 profiles 1 and 3 (not yet implemented)

And opportunistically mark a number of inputs
in IDL as required

  • timestamp (its required for creation of VideoFrame internally)
  • error and output callbacks (duh).

Remove ? from duration input dictionary. Its not required,
no need to null.

Bug: 1094166, 1116617

Change-Id: I9577bc42d1f24c2ec14885401e87337ba0937e43
Reviewed-on: https://chromium-review.googlesource.com/2355276
WPT-Export-Revision: 1e067b7e42a133437d515765c506a67eace2d731

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

TIMEOUT: 4
ERROR : 1

Chrome

TIMEOUT: 4
ERROR : 1

Safari

TIMEOUT: 4
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/webcodecs/video-encoder.html: ERROR (Chrome: ERROR, Safari: ERROR)
Test VideoEncoder.configure(): TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
Test VideoEncoder construction: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
Test successful configure(), encode(), and flush(): TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
Test encode() before configure() throws InvalidStateError.: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f800cf9dedfb [wpt PR 25027] - Misc bug fixes/features for webcodecs/VideoEncoder, a=testonly https://hg.mozilla.org/integration/autoland/rev/f78f4e1fed39 [wpt PR 25027] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.