1659340 - “Print preview” option is displayed inside the menu bar (File) even though the print preview will always open as the default option with the new print UI

Status: VERIFIED FIXED

(Toolkit :: Printing, enhancement, P1)

Description

[Emil Ghitta, QA [:emilghitta]]

Affected versions

• 81.0a1 (BuildId:20200815093117)

Affected platforms

• Windows 10 64bit
• Ubuntu 18.04 64bit.

Unaffected Platforms

• macOS 10.14

Preconditions

• Ensure that the print.tab_modal.enabled pref is set to true

Steps to reproduce

1. Launch Firefox.
2. Access a random page.
3. Enable the menu bar.
4. Open the “File” dropdown menu.

Expected result

• The print preview option is no longer displayed while the print.tab_modal.enabled is set to true

Actual result

• The print preview option is displayed.

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Good catch! I know the front-end team has talked about this before, but we didn't seem to have a bug filed about it…

Comment 3

[Emma Malysz]

Attachment: Bug 1659340, hide menu options if new print UI pref is enabled

If print.tab_modal.enabled is enabled, we should not display the print preview
menu item, as this will redirect us to the print preview automatically and thus
be redundant with the other print button.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8513e2bba101
hide menu options if new print UI pref is enabled r=mstriemer

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/8513e2bba101

Comment 6

[Emma Malysz]

Comment on attachment 9172047 [details]
Bug 1659340, hide menu options if new print UI pref is enabled

Beta/Release Uplift Approval Request

• User impact if declined: A windows user will be shown incorrect menu items in the file menu. Both print and print preview will redirect them to the same thing
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open firefox on Windows

2. Make sure print.tab_modal.enabled is on
3. Navigate to menu bar
4. Notice "Page Setup" and "print preview" items are now hidden

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): No strings
• String changes made/needed: n/a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172047 [details]
Bug 1659340, hide menu options if new print UI pref is enabled

Approved for 81.0b4.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7f6a0f8a6b8d

Comment 9

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 82.0a1 (BuildId:20200831091558) and Firefox 81.0b4 (BuildId:20200829200810) on Windows 10 64bit & Ubuntu 20.04.