1659369 - sw-wr: Crash in [@ mozilla::wr::RenderCompositorNative::AddSurface]

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Chris Peterson [:cpeterson]]

This bug is for crash report bp-d9d54b18-ea1f-41a4-93ea-a89b30200817.

Steps to reproduce

1. Enable gfx.webrender.software = true.
2. Load https://www.gap.com/browse/product.do?pid=544701022
3. Click the video play button on the left side of the page.

Result

Top 10 frames of crashing thread:

0 XUL mozilla::wr::RenderCompositorNative::AddSurface gfx/webrender_bindings/RenderCompositorNative.cpp:296
1 XUL <webrender_bindings::swgl_bindings::SwCompositor as webrender::composite::Compositor>::add_surface gfx/webrender_bindings/src/swgl_bindings.rs:1043
2 XUL webrender::renderer::Renderer::draw_frame gfx/wr/webrender/src/renderer.rs:6092
3 XUL webrender::renderer::Renderer::render_impl gfx/wr/webrender/src/renderer.rs:3626
4 XUL webrender::renderer::Renderer::render gfx/wr/webrender/src/renderer.rs:3403
5 XUL wr_renderer_render gfx/webrender_bindings/src/bindings.rs:609
6 XUL mozilla::wr::RendererOGL::UpdateAndRender gfx/webrender_bindings/RendererOGL.cpp:156
7 XUL mozilla::wr::RenderThread::UpdateAndRender gfx/webrender_bindings/RenderThread.cpp:482
8 XUL mozilla::wr::RenderThread::HandleFrameOneDoc gfx/webrender_bindings/RenderThread.cpp:360
9 XUL mozilla::detail::RunnableMethodImpl<mozilla::wr::RenderThread*, void  xpcom/threads/nsThreadUtils.h:1240

This crash is probably a regression from "sw-wr-feb" bug 1612941. I bisected this crash to this 76 Nightly pushlog:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8ef0a54d7715018ad09e5b6b53d3321252422e44&tochange=f39f8632d616f8ef271acee5c40971f79943dac0

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Windows_screenshot.png

The video crashes on macOS. On Windows, video fails to play the first time I click the Play button. If I reload the page and click Play again, the video plays but is stretched vertically. See the attached screenshot.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Windows_screenshot.png

Replacing the screenshot. I captured the first screenshot using Firefox's "Take a Screenshot", which produced an image that was not stretched. I captured this second screenshot using Windows itself and this image is stretched.

Comment 3

[Chris Peterson [:cpeterson]]

Closing as WORKSFORME because I can no longer reproduce this crash. I bisected the fix to SwCompositor bug 1622966:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e87bcd8a1f949b155dff0cc0c7cbad7f4fe03f77&tochange=754fccf0e73ac7c30d06a7ce5ac95ca1ea9300d6