Open Bug 1659375 Opened 4 years ago Updated 3 years ago

One-click keyword search doesn't allow keyword entry

Categories

(Firefox :: Search, defect, P5)

79 Branch
defect

Tracking

()

UNCONFIRMED

People

(Reporter: ksagar1030, Unassigned)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

Enter preferences -> search and scroll to one-click search engines. Attempt to add a keyword, but see that the keyword input area is non-responsive. Note that this is the Linux build on version 79.0, distributed via apt.

Verified this is also a problem on the pre-built binary for Firefox Nightly.

Actual results:

The keyword area is non-responsive.

Expected results:

The keyword area should allow inputs of some kind so that users can use one-click search with a keyword prefix.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Search

Have you tried double-clicking on the keyword area?

Flags: needinfo?(ksagar1030)

Yes. Unfortunately, no result. Same for right-clicking, typing various characters, etc.,

Clicking on a row in the table does highlight it, however.

Flags: needinfo?(ksagar1030)

Can you try going to the application menu (three bars) -> Web Developer -> Browser Console, and seeing if any errors appear there when you open preferences, or when you double-click within the keyword column next to an entry?

Flags: needinfo?(ksagar1030)
Flags: needinfo?(ksagar1030)

Yes, it looks like there are some errors. The top two errors (stack shown for the first) occur when I open preferences, and the last one occurs on each click. You can see it occurred multiple times; that was once for each click.

(In reply to Karan from comment #6)

Yes, it looks like there are some errors. The top two errors (stack shown for the first) occur when I open preferences, and the last one occurs on each click. You can see it occurred multiple times; that was once for each click.

That looks like it is coming from an add-on, could you try disabling some of your add-ons and seeing if that helps?

Flags: needinfo?(ksagar1030)

I tried it again with add-ons disabled. No console errors, but the problem persists. At any rate, aren't these extensions disabled on preferences pages?

Flags: needinfo?(ksagar1030)

The severity field is not set for this bug.
:daleharvey, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dharvey)

So this code has actually changed since you reported this bug, really not sure about why it wouldnt work on 79, this is a standard component so it being broken seems like a deeper problem. Could you try one of these things:

Could you try on an up to date nightly, the important thing is that the keywords field will have the internal keywords displayed (@google) and report if it works then?

On an older build where you are seeing the keywords editing not work, can you try:

  1. Press the star icon in the url bar to bookmark a page
  2. Click the expand / down arrow under the folder heading
  3. Try double clicking on a folder name and see if it becomes editable

That component uses the same <tree editable="true"' component, so want to see if its a problem with input / the component or just the search one

Flags: needinfo?(dharvey)
Flags: needinfo?(ksagar1030)

I get the same problem on the latest Nightly build (82.0a1 (2020-09-03) (64-bit)).

Clicking on the folder name as you asked closes the dropdown menu on the first click. If that's what you meant, then no, double-clicking on the folder name doesn't make it editable.

Thanks for looking into this!

Flags: needinfo?(ksagar1030)

The severity field is not set for this bug.
:daleharvey, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(dharvey)

Hi Karan

Do you mean clicking the folder name in this screen closes the dropdown menu completely? https://i.imgur.com/HzNzQdM.png

If not, can you get it into that editable state by double clicking?

Flags: needinfo?(dharvey) → needinfo?(ksagar1030)

Not reproducable so marking S4

Severity: -- → S4

Hi Dale -- I'm away from that particular computer for a bit, but if I recall clicking the folder name closes the dropdown menu completely. Double-clicking didn't do anything different.

However, I only tried it with folders nested at a depth of 1 ("Other Bookmarks", "Mobile Bookmarks", etc.,). I didn't have nested folders like you do.

Flags: needinfo?(ksagar1030)
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: