1659385 - l10n builds busted on nightly - FileNotFoundError: [Errno 2] No such file or directory: '/builds/worker/workspace/obj-build/comm/mail/locales/merge-dir/af/browser/defaultagent/defaultagent_localized.ini'

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: mkmelin+mozilla [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=313151544&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/CMcVZSBSS7q6sz3fs1WUGQ/runs/0/artifacts/public/logs/live_backing.log

---

Potentially from bug 1658682? Started with the dailies last Saturday

Comment 1

[Rob Lemley [:rjl]]

I believe this was brought on by (secure) bug 1633899. I think some #ifdefs are all that's needed.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1659385 - Do not build defaultagent for Thunderbird. r?darktrojan

Comment 3

[Rob Lemley [:rjl]]

Looking through what the defaultaagent service actually does, it doesn't make sense to include it with Thunderbird. Adding an imply_option call in comm/mail/moz.configure will stop it from being built by default for Thunderbird. (untested on try unfortunately.)

I suspect at the moment it is getting built for Thunderbird as well. Hopefully disabling it doesn't cause problems.

Comment 4

[Magnus Melin [:mkmelin]]

Disabling is likely to cause problems at least for tests :/

Comment 5

[Magnus Melin [:mkmelin]]

And who knows what down the line... all differences usually cause problems.

Comment 6

[Takanori MATSUURA]

This bug corrupts the comm-central-l10n build.
So, I would like this bug to set a higher Priority.

Comment 7

[Magnus Melin [:mkmelin]]

P5 is just how treeherder files these bugs... It's a priority, but we have the main builds busted now so need that fixed first.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0fe39da7ae20
Do not build defaultagent for Thunderbird. r=darktrojan

Comment 9

[Rob Lemley [:rjl]]

Discussed with mkmelin. Since this builds as a separate executable and runs as a background service we should not run into problems.

Comment 10

[Rob Lemley [:rjl]]

Unfortunately still a problem.

Comment 11

[Rob Lemley [:rjl]]

Attachment: Bug 1659385 - Only build defaultagent localization file if required. r?mhowell

Keep L10n repacks from trying to include defaultagent_localized.ini when it's
not needed. Thunderbird L10n repacks fail because this file is not present.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85669d311a46
Only build defaultagent localization file if required. r=mhowell

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/85669d311a46