1659405 - [wpt-sync] Sync PR 25034 - Consider directly composited images as covering the PictureTilingSet

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 25034 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25034
Details from upstream follow.

Daniel Libby <[e-mail]> wrote:

Consider directly composited images as covering the PictureTilingSet

For elements with will-change:transform or directly composited images
the raster scale is not updated in response to transform scale
changes. Once the scale gets especially large, the interest rect
computed by blink starts to become less than the layer bounds.
This ends up setting a recorded_viewport_ on RasterSource that is also
less than the layer bounds. If the interest rect gets small enough, it's
possible that tiles that are in view are not completely covered by the
RasterSource. This means that we won't create tiles (much less assign
them GPU memory and schedule them) in PictureLayerTiling::CreateTile. We
did not see this with the previous implementation of directly composited
images, since the content layer never had an interest rect computed.

This change fixes this specifically for directly composited images by
always considering its raster source as covering the entire layer. This
is the definition of directly composited images (has a DrawImageRectOp
that draws into the entire layer). This allows the in view tiles to be
created, then rasterized and activated and the image no longer
disappears.

I looked into fixing the general case (see comments in the bug) but
given the regression for the images scenario and the fact that we'd like
to get a fix merged for 85, I took an approach to just fix directly
composited images.

Bug: 1110141
Change-Id: Ice3cf25508585f116edd7317718292ec9ad8a7ef
Reviewed-on: https://chromium-review.googlesource.com/2358888
WPT-Export-Revision: 44e6a14b2425a234c775a154a3274e1bb23c7664

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=da894e6890273f3d9c85a8992041a5fef4a20607

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/semantics/embedded-content/the-img-element/image-compositing-large-scale-change.html: FAIL [Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, GitHub] (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e6c3519c33a0
[wpt PR 25034] - Consider directly composited images as covering the PictureTilingSet, a=testonly
https://hg.mozilla.org/integration/autoland/rev/9d1a47551c44
[wpt PR 25034] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e6c3519c33a0
https://hg.mozilla.org/mozilla-central/rev/9d1a47551c44