1659539 - Stop using pipenv to manage |mach python-test|

Status: RESOLVED FIXED

(Testing :: Python Test, task, P3)

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1659539 - [python-test] Remove '--python' and stop using pipenv to manage virtualenvs

Pipenv is heavy weight and overkill for the purposes it is being used. We'd
like to remove it from the tree and |mach python-test| was one of the last
remanining use cases.

Rather than re-implementing the ability to specify a Python version via the
'--python' flag, this simply runs |mach python-test| with whatever Python
mach is running with.

This means that |mach python-test| will now use Python 3 by default. If
py2 tests are needed, then |python2 mach python-test| can be used instead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fffa3fcb1881
[python-test] Remove '--python' and stop using pipenv to manage virtualenvs r=ahal

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/fffa3fcb1881

Comment 4

[Mitchell Hentges [:mhentges] 🦀]

Comment on attachment 9172185 [details]
Bug 1659539 - [python-test] Remove '--python' and stop using pipenv to manage virtualenvs

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Needed to uplift https://phabricator.services.mozilla.com/D92173.
  Otherwise, there's "sitecustomize" errors (and potentially other problems) because pipenv doesn't play nice with the new virtualenv version.
• User impact if declined: None
• Fix Landed on Version: 82
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's a build-only patch
• String or UUID changes made by this patch:

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9172185 [details]
Bug 1659539 - [python-test] Remove '--python' and stop using pipenv to manage virtualenvs

Needed to better support running mach on newer macOS releases. Approved for 78.8esr.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/a8280827e0aa

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/1c33c2b6c76e