1659595 - Avoid creating atoms for BigInt property names

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

BigInt property keys need to be normalized to strings during parsing. This is currently done by allocating both a BigInt and a JSString. Instead we need something compatible with ParserAtom type.

This is a silly syntax and likely will rarely be used. We can do a naive normalization into a ParserAtom and that is probably good enough.

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1659595 - Avoid creating atoms for BigInts when parsing r?jorendorff!,tcampbell!,jandem!

This parses numeric property names as if they were computed, which means we don't end up neeeding to atomize
them.

This does mean that numeric property names take a slower path on construction, meaning that it is possible
to measure a slowdown on executing the construction of a huge literal with thousands of numeric properties.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bea475748ad2
Avoid creating atoms for BigInts when parsing r=jorendorff,tcampbell,jandem

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bea475748ad2