1659600 - OpenPGP signature status not shown if message opened from file

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

Save an encrypted and signed OpenPGP message to a file (file save as), then use file open saved message to open that file.

The encryption status will be shown, but signature status will not.

The fix from bug 1652657 was incomplete, and is even incorrect in some scenarios.

Comment 1

[Kai Engert [:KaiE:]]

Regarding this commit:
https://hg.mozilla.org/comm-central/rev/d025476d178d

Handling "file" like mailbox doesn't work, because for "file" URIs, it's possible there isn't any number parameter, and consequently msgNum will be undefined. However, we want msgNum to be "0".

Based on my limited understanding of the mail URIs, I think that a file:// URI will always refer to a single message, only. If that's true, then we can simply assign msgNum = "0";

Removing number=0 from pathQueryRef is wrong, because for mailboxes we need the number. And the replace call doesn't work if it starts with ?number=0 . I think we need to remove the "replace" call that was added in the above commit.

In mimeVerify we have code that simply compares the pathQueryRef part of URIs, while one side could contain a number, and the other doesn't. It seems reasonable to use msgIdentificationFromUrl in that place, too, and compare the derived values.

Comment 2

[Kai Engert [:KaiE:]]

Attachment: Bug 1659600 - OpenPGP signature status not shown if message opened from file. r=PatrickBrunschwig

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c73e666bb86e
OpenPGP signature status not shown if message opened from file. r=PatrickBrunschwig DONTBUILD

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9170537 [details]
Bug 1659600 - OpenPGP signature status not shown if message opened from file. r=PatrickBrunschwig

OpenPGP correctness fix, low risk

Comment 5

[Wayne Mery (:wsmwk)]

Will take for esr. We're past the last 80 beta

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9170537 [details]
Bug 1659600 - OpenPGP signature status not shown if message opened from file. r=PatrickBrunschwig

[Triage Comment]
Approved for esr78

Comment 7

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-esr78/rev/c68345587e68e4e786241cf184f9e6301c11d048