Closed Bug 1659608 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 25063 - Move location.fragmentDirective to document

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox82 fixed)

Status:
RESOLVED FIXED
Milestone:
82 Branch
Tracking Flags:
Tracking Status
firefox82 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 25063 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/25063
Details from upstream follow.

David Bokan <bokan@chromium.org> wrote:

Move location.fragmentDirective to document

This CL moves the window.location.fragmentDirective object, used for
feature detecting support for text fragments, to
document.fragmentDirective.

This is a web-facing change. Intent-to-ship thread:

https://groups.google.com/a/chromium.org/d/msg/blink-dev/ygBV2vWIX-o/kbYwrJgDAgAJ

Bug: 1057795
Change-Id: I1a7df51a1cde4c39a3595d7d83b118403db5cd5e

Reviewed-on: https://chromium-review.googlesource.com/2343634
WPT-Export-Revision: c1a18b1a27c2c92dee18ff6c8d4221ef6145bd4e

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 2 subtests

Status Summary

Firefox

OK : 1
FAIL: 2

Chrome

OK : 1
FAIL: 2

Safari

OK : 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-to-text-fragment/scroll-to-text-fragment-api.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Scroll to text is feature detectable via document.fragmentDirective: FAIL (Chrome: FAIL, Safari: FAIL)
Setting document.fragmentDirective has no effect: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/scroll-to-text-fragment/scroll-to-text-fragment-api.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e392dabab15
[wpt PR 25063] - Move location.fragmentDirective to document, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2e392dabab15

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox82: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
You need to log in before you can comment on or make changes to this bug.