1659630 - Enable BrowsingContext preservation in early beta

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, task, P1)

Description

[Paul Bone [:pbone]]

Relman have advised that we don't need an experiment for BC Preservation at this stage. We can enable BC preservation in early beta, if it looks good in early beta we may uplift a patch to let it ride to late beta and release.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1659630 - Enable BrowsingContext preservation in early beta r=cpeterson

Comment 2

[Paul Bone [:pbone]]

Note that this is mostly-unused code on mobile, so by going to beta we're also going to beta on mobile and that's okay.

We're also waiting on QA, we expect to hear from them by Friday the 21st, merge day is the 24th.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d79778c6e1e
Enable BrowsingContext preservation in early beta r=cpeterson

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4d79778c6e1e

Comment 5

[Brendan Dahl [:bdahl]]

Not sure which bug to file the regression on, feel free to move it...

After this change browser_pdfjs_saveas.js starts hanging when using a release build. The test ends up hanging on BrowserTestUtils.waitForContentEvent on a browser that loads a file uri. The event makes it back to the parent process but fails this check.

Running with fission.preserve_browsing_contexts=true the test runs fine.

Comment 6

[Chris Peterson [:cpeterson]]

Thanks, Brendan. I'll follow up in bug 1661173.

Comment 7

[Paul Bone [:pbone]]

Given that we've had BC preservation in nightly for a while, and that's where a lot of testing happens. It may almost be safer to let it ride since that might be the more well tested configuration.