Closed Bug 1659647 Opened 4 years ago Closed 4 years ago

CreateStorageConnection returns bad result when opening a database fails during origin initialization

Categories

(Core :: Storage: IndexedDB, defect, P3)

Product:
Core
Component:
Storage: IndexedDB
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- unaffected
firefox79 --- wontfix
firefox80 --- wontfix
firefox81 --- fixed

People

(Reporter: sg, Assigned: sg)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1659647 - Correctly propagate error of OpenDatabaseAndHandleBusy in CreateStorageConnection. r=#dom-workers-and-storage
47 bytes, text/x-phabricator-request
Details | Review

At https://searchfox.org/mozilla-central/rev/2f9eacd9d3d995c937b4251a5557d95d494c9be1/dom/indexedDB/ActorsParent.cpp#4106, Err(rv) is returned, but rv is NS_OK here rather than NS_ERROR_FILE_CORRUPTED, which should actually be returned.

Despite being the wrong result, Err(NS_OK) will trigger a debug assertion failure at https://searchfox.org/mozilla-central/rev/fa7f47027917a186fb2052dee104cd06c21dd76f/mfbt/ResultExtensions.h#30

Assignee: nobody → sgiesecke
Status: NEW → ASSIGNED
Pushed by sgiesecke@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/23a83f1c6b22
Correctly propagate error of OpenDatabaseAndHandleBusy in CreateStorageConnection. r=dom-workers-and-storage-reviewers,janv
Severity: -- → S4
Priority: -- → P3

Set release status flags based on info from the regressing bug 1623278

status-firefox79: --- → affected
status-firefox80: --- → affected
status-firefox81: --- → affected
status-firefox-esr68: --- → unaffected
status-firefox-esr78: --- → unaffected

https://hg.mozilla.org/mozilla-central/rev/23a83f1c6b22

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox81: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: